blockifier: regenerate VC JSONs#14133
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryHigh Risk Overview Refreshes fee/resource accounting data, including Reviewed by Cursor Bugbot for commit 86c33ac. Bugbot is set up for automated code reviews on this repo. Configure here. |
dorimedini-starkware
left a comment
There was a problem hiding this comment.
what changes? everything only moved
@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 19 files reviewed, all discussions resolved (waiting on Yoni-Starkware).
1a8dafe to
7900ce5
Compare
bb0248d to
42de62b
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 16 files and all commit messages, and made 2 comments.
Reviewable status: 16 of 19 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).
crates/blockifier/resources/versioned_constants_diff_regression/0.13.3_0.13.4.txt line 17 at r1 (raw file):
~ /os_constants/builtin_gas_costs/range_check96: 56 ~ /os_constants/execute_max_sierra_gas: 1000000000 ~ /os_constants/syscall_gas_costs: null
Why this change?
Code quote:
~ /os_constants/syscall_gas_costs: nullcrates/blockifier/resources/versioned_constants_diff_regression/0.13.4_0.13.5.txt line 1 at r1 (raw file):
+ /os_constants/v1_bound_accounts_cairo0/0: "0x06d706cfbac9b8262d601c38251c5fbe0497c3a96cc91a92b08d91b61d9e70c4"
why?
Code quote:
0x06d706cfbac9b8262d601c38251c5fbe0497c3a96cc91a92b08d9
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 3 files.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).
42de62b to
c2e94f5
Compare
7900ce5 to
445c946
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Yoni-Starkware).
crates/blockifier/resources/versioned_constants_diff_regression/0.13.4_0.13.5.txt line 1 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
why?
you are asking why the leading zero is dropped?
because this is the serialization of a contract address, i suppose.
is it a problem? the strings in the VC JSONs are not meant to be parsed without going through RawVersionedConstants, in which case the values are the same (same ContractAddress)
crates/blockifier/resources/versioned_constants_diff_regression/0.13.3_0.13.4.txt line 17 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Why this change?
I didn't annotate this field with #[serde(skip_serializing_if = "Option::is_none")]. fixed
c2e94f5 to
9e3ca3f
Compare
445c946 to
9a01c71
Compare
9e3ca3f to
cadbc3a
Compare
9a01c71 to
7f585f7
Compare
|
Artifacts upload workflows: |
7f585f7 to
86c33ac
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 15 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

No description provided.