Skip to content

blockifier: regenerate VC JSONs#14133

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-22-blockifier_regenerate_vc_jsons
May 24, 2026
Merged

blockifier: regenerate VC JSONs#14133
dorimedini-starkware merged 1 commit into
mainfrom
05-22-blockifier_regenerate_vc_jsons

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

High Risk
Updates protocol versioned constants (limits, step/builtin/syscall gas costs, and OS resource accounting) for multiple 0.13.x Starknet versions, which can change fee calculation and transaction acceptance behavior. Risk is high because these constants directly affect execution/resource metering across versions.

Overview
Regenerates the blockifier_versioned_constants_0_13_{0..3}.json resources with updated limits (e.g., tx_event_limits, gateway size caps, max steps) and feature flags (e.g., segment_arena_cells, ignore_inner_event_resources).

Refreshes fee/resource accounting data, including vm_resource_fee_cost, expanded per-syscall gas cost breakdowns (adding fields like range_check, bitwise, memory_hole_gas_cost), updated OS execution resource tables, and version-specific compute_os_kzg_commitment_info/rounding constants.

Reviewed by Cursor Bugbot for commit 86c33ac. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what changes? everything only moved

@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 19 files reviewed, all discussions resolved (waiting on Yoni-Starkware).

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 16 files and all commit messages, and made 2 comments.
Reviewable status: 16 of 19 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).


crates/blockifier/resources/versioned_constants_diff_regression/0.13.3_0.13.4.txt line 17 at r1 (raw file):

~ /os_constants/builtin_gas_costs/range_check96: 56
~ /os_constants/execute_max_sierra_gas: 1000000000
~ /os_constants/syscall_gas_costs: null

Why this change?

Code quote:

~ /os_constants/syscall_gas_costs: null

crates/blockifier/resources/versioned_constants_diff_regression/0.13.4_0.13.5.txt line 1 at r1 (raw file):

+ /os_constants/v1_bound_accounts_cairo0/0: "0x06d706cfbac9b8262d601c38251c5fbe0497c3a96cc91a92b08d91b61d9e70c4"

why?

Code quote:

0x06d706cfbac9b8262d601c38251c5fbe0497c3a96cc91a92b08d9

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 3 files.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).

@graphite-app graphite-app Bot changed the base branch from 05-21-blockifier_raw_vc_to_string_pretty to graphite-base/14133 May 24, 2026 11:29
@dorimedini-starkware dorimedini-starkware force-pushed the 05-22-blockifier_regenerate_vc_jsons branch from 7900ce5 to 445c946 Compare May 24, 2026 11:31
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14133 to 05-21-blockifier_raw_vc_to_string_pretty May 24, 2026 11:31
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Yoni-Starkware).


crates/blockifier/resources/versioned_constants_diff_regression/0.13.4_0.13.5.txt line 1 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

why?

you are asking why the leading zero is dropped?
because this is the serialization of a contract address, i suppose.
is it a problem? the strings in the VC JSONs are not meant to be parsed without going through RawVersionedConstants, in which case the values are the same (same ContractAddress)


crates/blockifier/resources/versioned_constants_diff_regression/0.13.3_0.13.4.txt line 17 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Why this change?

I didn't annotate this field with #[serde(skip_serializing_if = "Option::is_none")]. fixed

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_raw_vc_to_string_pretty branch from c2e94f5 to 9e3ca3f Compare May 24, 2026 11:41
@dorimedini-starkware dorimedini-starkware force-pushed the 05-22-blockifier_regenerate_vc_jsons branch from 445c946 to 9a01c71 Compare May 24, 2026 11:41
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-blockifier_raw_vc_to_string_pretty to graphite-base/14133 May 24, 2026 12:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-22-blockifier_regenerate_vc_jsons branch from 9a01c71 to 7f585f7 Compare May 24, 2026 12:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 24, 2026

@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14133 to main May 24, 2026 12:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-22-blockifier_regenerate_vc_jsons branch from 7f585f7 to 86c33ac Compare May 24, 2026 13:12
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 15 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 24, 2026
Merged via the queue into main with commit 81fb8b8 May 24, 2026
39 of 42 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants