Skip to content

starknet_os: os resources test - extract setup_test_builder#14145

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_secp_syscallsfrom
05-24-starknet_os_os_resources_test_-_extract_setup_test_builder
Open

starknet_os: os resources test - extract setup_test_builder#14145
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_secp_syscallsfrom
05-24-starknet_os_os_resources_test_-_extract_setup_test_builder

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Test-only refactor in flow tests; no production OS or blockifier behavior changes.

Overview
Pulls shared OS-resources test harness setup into setup_test_builder, so both test_fee_transfer_syscalls and test_os_resources_regression use the same path instead of duplicating (or diverging on) builder creation.

The helper centralizes deploying and funding the OS-resources account, bumping min_sierra_version_for_sierra_gas to force step-tracking mode, declaring the deployable measurement class, and advancing a block so measurement transactions sit alone. test_fee_transfer_syscalls now calls this helper (replacing TestBuilder::create_standard) and only adds its invoke plus syscall assertions; the regression test drops its inlined copy of that setup. Imports add ClassHash and ContractAddress for the helper’s return type.

Reviewed by Cursor Bugbot for commit 72ceed8. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d2589c6. Configure here.

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs Outdated
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from e669ac7 to f5a424e Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from d2589c6 to 15ddac2 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from f5a424e to ac5afa2 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from 15ddac2 to 72ceed8 Compare May 24, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants