Skip to content

starknet_os: os resources test - deploy account tx calldata factor#14151

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factorfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor
Open

starknet_os: os resources test - deploy account tx calldata factor#14151
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factorfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Changes fee/resource accounting constants used for transaction charging; incorrect values could under- or over-charge users, though values are regression-tested against the OS.

Overview
Extends test_execute_txs_inner_resources so deploy-account OS overhead is measured with a base deploy (minimal constructor calldata) and an extra deploy (one more constructor felt), then derives the scaled calldata factor from their difference—matching the existing invoke pattern instead of only setting the constant term.

Updates blockifier_versioned_constants_0_14_3.json execute_txs_inner calldata factors from those measurements: DeployAccount per-unit costs drop (e.g. steps 37→26, one fewer Pedersen), and InvokeFunction per-unit costs drop sharply (steps 15→3, Poseidon removed from the factor).

Reviewed by Cursor Bugbot for commit b07e51e. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from b4fd833 to 77fc062 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 04d3d51 to 5af6585 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from 77fc062 to b07e51e Compare May 24, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants