Skip to content

starknet_os: os resources test - create fixed deployable account#14173

Open
dorimedini-starkware wants to merge 1 commit into
05-21-starknet_os_os_resources_test_-_library_callfrom
05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account
Open

starknet_os: os resources test - create fixed deployable account#14173
dorimedini-starkware wants to merge 1 commit into
05-21-starknet_os_os_resources_test_-_library_callfrom
05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Test-only fixtures and setup in starknet_os_flow_tests; no production runtime or security paths changed.

Overview
Adds a pinned dummy Starknet account contract (deployable_for_resource_measurement) with checked-in Sierra/CASM artifacts (compiler v2.17.0) so deploy-related OS resource measurements stay stable when the main Cairo toolchain moves.

special_contracts.rs exposes lazy-loaded Sierra/CASM handles for that class. test_os_resources_regression now declares it on-chain from FUNDED_ACCOUNT_ADDRESS (with V2 compiled class hash and ClassInfo) before advancing to the block that runs syscall measurement, so the measurement harness can deploy a known class instead of one that would change with recompiles or address normalization.

Reviewed by Cursor Bugbot for commit 91c50c1. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch 2 times, most recently from 6266963 to b45291c Compare May 25, 2026 09:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from 24bc2a4 to 7facbbd Compare May 25, 2026 09:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from 7facbbd to bf48e42 Compare May 25, 2026 15:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch from b45291c to 91c50c1 Compare May 25, 2026 15:37
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants