Skip to content

starknet_os: os resources test - declare tx#14147

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_declare_tx
Open

starknet_os: os resources test - declare tx#14147
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_declare_tx

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Changes fee/resource constants used by the blockifier for declare txs; incorrect values would mis-estimate gas, though the update is test-driven regression output.

Overview
Extends the OS execute_txs_inner regression test so declare transactions are measured the same way as invoke: full OS trace minus blockifier validate/execute resources, then written back into versioned constants.

The test now runs two minimal txs (noop invoke + declare of a fixed data gas account artifact), asserts declare uses a constant overhead entry, and refreshes blockifier_versioned_constants_0_14_3.json (e.g. declare n_steps 3523→3933, range_check_builtin 72→92). The OS resources test account’s __validate_declare__ signature is trimmed to (class_hash) only so declare validation stays minimal/stable.

Reviewed by Cursor Bugbot for commit 25d975a. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from fbfd93e to f4340dd Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from 3ad85f3 to c632d3d Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from c632d3d to e678a92 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from f4340dd to 25d975a Compare May 24, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants