Skip to content

blockifier_test_utils: add OS resources measurement contract#14126

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-21-blockifier_test_utils_add_os_resources_measurement_contract
May 25, 2026
Merged

blockifier_test_utils: add OS resources measurement contract#14126
dorimedini-starkware merged 1 commit into
mainfrom
05-21-blockifier_test_utils_add_os_resources_measurement_contract

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 21, 2026

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_test_utils_add_os_resources_measurement_contract branch from 9b22fec to 1e1aa17 Compare May 21, 2026 13:49
@dorimedini-starkware dorimedini-starkware changed the base branch from main to graphite-base/14126 May 24, 2026 06:44
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_test_utils_add_os_resources_measurement_contract branch from 1e1aa17 to 40409e1 Compare May 24, 2026 06:50
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14126 to 05-22-blockifier_regenerate_vc_jsons May 24, 2026 06:50
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 24, 2026

Artifacts upload workflows:

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Test-only fixture and enum registration in blockifier_test_utils; no production execution or fee logic changes.

Overview
Adds a Cairo 1 account feature contract used to exercise per-syscall OS resource measurement. Its __execute__ path invokes call_contract_syscall against an on-contract empty_function, with standard validate hooks returning VALIDATED.

Registers OsResourcesTest on the existing FeatureContract machinery (mock class hash base 23, name os_resources_test_contract, same Cairo1/CASM/native patterns as other account-style test contracts).

Reviewed by Cursor Bugbot for commit 92daa01. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware changed the base branch from 05-22-blockifier_regenerate_vc_jsons to graphite-base/14126 May 24, 2026 11:30
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_test_utils_add_os_resources_measurement_contract branch from 26755a8 to 717e243 Compare May 24, 2026 11:41
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14126 to 05-22-blockifier_regenerate_vc_jsons May 24, 2026 11:41
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_test_utils_add_os_resources_measurement_contract branch from 717e243 to 599963c Compare May 24, 2026 12:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-22-blockifier_regenerate_vc_jsons branch from 9a01c71 to 7f585f7 Compare May 24, 2026 12:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_test_utils_add_os_resources_measurement_contract branch from 599963c to b3e44b0 Compare May 24, 2026 13:12
@dorimedini-starkware dorimedini-starkware force-pushed the 05-22-blockifier_regenerate_vc_jsons branch from 7f585f7 to 86c33ac Compare May 24, 2026 13:12
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-22-blockifier_regenerate_vc_jsons to main May 24, 2026 15:40
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_test_utils_add_os_resources_measurement_contract branch from b3e44b0 to 92daa01 Compare May 24, 2026 17:03
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 92daa01. Configure here.

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 25, 2026
Merged via the queue into main with commit 7ca8faf May 25, 2026
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants