Skip to content

starknet_os: os resources test - l1 handler tx calldata factor#14152

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factorfrom
05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor
Open

starknet_os: os resources test - l1 handler tx calldata factor#14152
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factorfrom
05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Changes only OS flow-test resource regression logic; production behavior updates only if the versioned-constants snapshot is regenerated in the same change.

Overview
Extends test_execute_txs_inner_resources so L1 handler OS overhead is measured like invoke and deploy-account: a base minimal handler plus a second tx with one extra calldata element, raising N_TXS from 6 to 7.

For TransactionType::L1Handler, the test now sets constant to the base overhead and calldata_factor to an unscaled delta between extra and base (replacing a single combined overhead and removing the TODO to compute the linear factor). The updated values are still checked against the latest versioned constants JSON via expect_file.

Reviewed by Cursor Bugbot for commit 7505307. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor branch from 5dbac28 to d5aaebf Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from 77fc062 to b07e51e Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor branch from d5aaebf to 7505307 Compare May 24, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants