starknet_os: os resources test - invoke tx constant factor

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_os: os resources test - l1 handler tx calldata factor #14152
• starknet_os: os resources test - deploy account tx calldata factor #14151
• starknet_os: os resources test - invoke tx calldata factor #14150
• starknet_os: os resources test - l1 handler tx constant factor #14149
• starknet_os: os resources test - deploy account tx constant factor #14148
• starknet_os: os resources test - declare tx #14147
• starknet_os: os resources test - invoke tx constant factor #14146 👈 (View in Graphite)
• starknet_os: os resources test - extract setup_test_builder #14145
• starknet_os: os resources test - add secp syscalls #14144
• starknet_os: os resources test - add send_message_to_l1 #14143 : 1 other dependent PR (#14153 )
• starknet_os: os resources test - add replace_class #14142
• starknet_os: os resources test - support virtual builtins, add sha256 #14141
• starknet_os: define sha256 batch resources constants #14140
• starknet_os: os resources test - add keccak #14139
• starknet_os: os resources test - add 3 more syscalls #14138
• starknet_os: os resources test - remove all fee transfer syscalls #14137
• starknet_os: os resources test - add emit event #14136
• starknet_os: os resources test - add meta tx #14135
• starknet_os: os resources test - measure linear factor, add deploy #14134
• starknet_os: os resources test - create fixed deployable account #14173
• starknet_os: os resources test - library call #14129
• starknet_os: initial test, measure call contract resources #14128
• blockifier_test_utils: add OS resources measurement contract #14126 : 1 other dependent PR (#14127 )
• blockifier: regenerate VC JSONs #14133
• blockifier: raw VC to_string_pretty #14132
• blockifier: raw VC deterministic map order #14131
• blockifier: raw VC serde equivalence test #14130
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Changes are test-driven resource accounting updates and JSON constants for fee estimation; no runtime execution-path logic changes.

Overview
Adds test_execute_txs_inner_resources, which runs a minimal invoke through the full OS, subtracts blockifier execute/validate VM resources from the OS trace, and treats the remainder as the execute_txs_inner constant for InvokeFunction. The test asserts the existing calldata scaling factor of 2 and snapshots the updated constants via expect_file.

blockifier_versioned_constants_0_14_3.json is bumped for invoke inner overhead: n_steps 4348→4810, range_check_builtin 90→110, poseidon_builtin 12→14. Linear calldata cost is left for a follow-up (TODO in test).

^{Reviewed by Cursor Bugbot for commit e678a92. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e678a92. Configure here.}

[cursor]

Constant includes calldata-dependent cost, causing double-counting

Medium Severity

The measured invoke_overhead includes calldata-dependent OS cost for the 4 calldata elements used in the test, but it's assigned entirely to invoke_resources_params.constant without subtracting the calldata factor contribution. Since resources_for_tx_type computes constant + calldata_factor * calldata_len / scaling_factor, the calldata cost for the test's 4 elements is permanently baked into the constant and double-counted for every transaction. This inflates the constant by approximately 22 n_steps and 2 poseidon_builtin (the entire poseidon increase from 12→14 is from this inflation).

Additional Locations (1)

• crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json#L518-L524

 

^{Reviewed by Cursor Bugbot for commit e678a92. Configure here.}