Skip to content

blockifier: raw VC deterministic map order#14131

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-21-blockifier_raw_vc_deterministic_map_order
May 24, 2026
Merged

blockifier: raw VC deterministic map order#14131
dorimedini-starkware merged 1 commit into
mainfrom
05-21-blockifier_raw_vc_deterministic_map_order

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Switching from HashMap to BTreeMap changes iteration/serialization order and requires new Ord implementations, which could affect any logic or tests that implicitly relied on prior map ordering or type aliases.

Overview
Makes versioned-constants deserialization/serialization deterministic by replacing several HashMap fields/type aliases with BTreeMap (notably SyscallGasCostsMap, VmResourceCosts.builtins, and RawOsResources syscall/tx maps), and updates related helper functions and tests accordingly.

To support ordered maps, adds Ord/PartialOrd derives to key enums (TransactionType and DeprecatedSyscallSelector) and adjusts call sites (e.g., fee calculation) to accept the new ordered map types.

Reviewed by Cursor Bugbot for commit 7858610. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-blockifier_raw_vc_serde_equivalence_test to main May 24, 2026 10:58
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_raw_vc_deterministic_map_order branch from 307a01f to 7858610 Compare May 24, 2026 10:58
@github-actions
Copy link
Copy Markdown

Artifacts upload workflows:

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 24, 2026

Merge activity

  • May 24, 10:59 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 24, 2026
Merged via the queue into main with commit 1549563 May 24, 2026
38 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants