starknet_os: os resources test - add meta tx#14135
Conversation
PR SummaryMedium Risk Overview Measured MetaTxV0 OS overhead in The flow test drops MetaTxV0 from unmeasurable syscalls, extends invoke calldata for Reviewed by Cursor Bugbot for commit f30d4c1. Bugbot is set up for automated code reviews on this repo. Configure here. |
08dbf97 to
f7fd3a3
Compare
311e125 to
a775a63
Compare
f7fd3a3 to
3ca8f12
Compare
a775a63 to
268457e
Compare
dafb7a8 to
ce6eb29
Compare
268457e to
8b293fb
Compare
ce6eb29 to
f48908d
Compare
8b293fb to
bd9c3be
Compare
f48908d to
f30d4c1
Compare
bd9c3be to
9711ff8
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 69 at r1 (raw file):
calldata: array![0, 0, 0, 0].span(), signature: array![].span(), )
Call the const contract instead, so you could have a base cost without arguments (same comment as the deploy syscall)
Code quote:
// meta_tx_v0 syscall - base.
meta_tx_v0_syscall(
address: self_address,
entry_point_selector: EXECUTE_FUNCTION_SELECTOR,
// class hash, address, deployable class hash, extra args len.
calldata: array![0, 0, 0, 0].span(),
signature: array![].span(),
)
No description provided.