Skip to content

blockifier: raw VC to_string_pretty#14132

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-21-blockifier_raw_vc_to_string_pretty
May 24, 2026
Merged

blockifier: raw VC to_string_pretty#14132
dorimedini-starkware merged 1 commit into
mainfrom
05-21-blockifier_raw_vc_to_string_pretty

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Low risk: test-only change that alters how RawVersionedConstants is pretty-serialized to JSON, with no runtime behavior impact outside tests.

Overview
Adds a test-only RawVersionedConstants::to_string_pretty() that pretty-prints JSON with a fixed 4-space indent via a custom serde_json formatter.

Updates the roundtrip serde test to use this helper instead of serde_json::to_string_pretty, making the expected serialization format explicit and consistent.

Reviewed by Cursor Bugbot for commit 9e3ca3f. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@graphite-app graphite-app Bot changed the base branch from 05-21-blockifier_raw_vc_deterministic_map_order to graphite-base/14132 May 24, 2026 10:58
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_raw_vc_to_string_pretty branch from 42de62b to c2e94f5 Compare May 24, 2026 11:29
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 24, 2026

@graphite-app graphite-app Bot changed the base branch from graphite-base/14132 to main May 24, 2026 11:29
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 24, 2026

Merge activity

  • May 24, 11:29 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_raw_vc_to_string_pretty branch from c2e94f5 to 9e3ca3f Compare May 24, 2026 11:41
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 24, 2026
Merged via the queue into main with commit cadbc3a May 24, 2026
33 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants