Skip to content

starknet_os: os resources test - l1 handler tx constant factor#14149

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor
Open

starknet_os: os resources test - l1 handler tx constant factor#14149
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Test and versioned-constants tuning for fee/OS resource accounting; no runtime auth or execution-path logic changes beyond updated constants used for charging.

Overview
Extends the OS execute_txs_inner regression test to cover L1 handler transactions alongside invoke, declare, and deploy-account. A minimal empty_l1_handler entry point is added on the OS resources test contract, and the flow test runs a fourth minimal L1-handler tx and derives pure OS scaffolding overhead (OS trace minus blockifier business logic) for that type.

The measured constant overhead for L1Handler in blockifier_versioned_constants_0_14_3.json is updated (n_steps 1315 → 1339, pedersen_builtin 11 → 12). The existing unscaled calldata-factor shape is asserted but not recomputed (TODO remains for the linear factor).

Reviewed by Cursor Bugbot for commit cb37a07. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from b5eae2f to 4a8df3d Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 43d9d8e to 3e2e6c5 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 4a8df3d to dc5adbd Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 3e2e6c5 to cb37a07 Compare May 24, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants