Skip to content

starknet_os: os resources test - deploy account tx constant factor#14148

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_declare_txfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor
Open

starknet_os: os resources test - deploy account tx constant factor#14148
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_declare_txfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Test and fee/resource constant calibration only; no runtime logic changes beyond updated JSON constants used for resource accounting.

Overview
Extends the test_execute_txs_inner_resources flow test so DeployAccount is measured alongside invoke and declare: a minimal deploy-account tx is prepared (with funding in a prior block), run through the full OS, and the constant execute_txs_inner overhead is derived as OS trace minus blockifier validate/execute resources.

The test contract gains a trivial __validate_deploy__ entry point so deploy-account validation stays minimal and stable. blockifier_versioned_constants_0_14_3.json is updated with the new measured DeployAccount constant (higher step and builtin counts); calldata scaling factor 2 is asserted unchanged.

Reviewed by Cursor Bugbot for commit dc5adbd. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from fbfd93e to f4340dd Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from b5eae2f to 4a8df3d Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 4a8df3d to dc5adbd Compare May 24, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants