starknet_os: os resources test - add 3 more syscalls#14138
Conversation
PR SummaryMedium Risk Overview The Cairo1 Reviewed by Cursor Bugbot for commit 5d943b5. Bugbot is set up for automated code reviews on this repo. Configure here. |
0d44efb to
cd7ac82
Compare
818a408 to
e55a063
Compare
cd7ac82 to
72d6d62
Compare
e55a063 to
01423bf
Compare
72d6d62 to
ba9b395
Compare
01423bf to
5d943b5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5d943b5. Configure here.
| @@ -1,2 +1,2 @@ | |||
| ~ /enable_casm_hash_migration: true | |||
| + /os_constants/allowed_virtual_os_program_hashes/1: "0x4fb8c0cb28349d61091f3fc633493c01385f77cd0d4ebfd577251b3941d49b9" | |||
| + /os_constants/allowed_virtual_os_program_hashes/1: "0x7b33f87bb36acce52d403e202c5d490d316910ab68d6264c9afde698ad52fc6" | |||
There was a problem hiding this comment.
Diff regression file missing OS resource changes
Medium Severity
The 0.14.2_0.14.3.txt diff regression file only captures the allowed virtual OS program hash change, but the PR also modifies OS resource values in the 0.14.3 JSON that differ from 0.14.2: GetBlockHash n_steps (107→106) and range_check_builtin (2→3), GetClassHashAt n_steps (89→75), and GetExecutionInfo n_steps (125→111). Since the 0.14.2 JSON was not changed, the test_vc_diffs_regression test will compute these as Replace operations in the JSON diff but the expected file doesn't include them, causing the test to fail.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5d943b5. Configure here.
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 104 at r1 (raw file):
// get execution info syscall. get_execution_info_v2_syscall().unwrap_syscall();
Same OS impl though
Suggestion:
get_execution_info_v3_syscall()


No description provided.