Skip to content

starknet_os: os resources test - add send_message_to_l1#14143

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_replace_classfrom
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1
Open

starknet_os: os resources test - add send_message_to_l1#14143
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_replace_classfrom
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 24, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 24, 2026 07:03
@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Changes syscall gas/step constants and OS program hashes used for proving and fee accounting; incorrect values would affect resource bounds and OS identity checks.

Overview
Send message to L1 is now part of the OS resources regression path instead of being skipped as unmeasurable.

The measurement contract invokes send_message_to_l1_syscall with an empty payload, and the flow test asserts the resulting L1 message. SendMessageToL1 is removed from the unmeasurable syscall list so its VM steps are captured like other syscalls. Reported costs are lowered consistently: SEND_MESSAGE_TO_L1_GAS_COST (14470 → 12270), blockifier SendMessageToL1 n_steps (144 → 122), and program_hash.json OS hashes are regenerated to match the updated Cairo OS program.

Reviewed by Cursor Bugbot for commit b4dc505. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from 9534bec to ed548b5 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from 39edd2e to b4dc505 Compare May 24, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants