Skip to content

blockifier: raw VC serde equivalence test#14130

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-21-blockifier_raw_vc_serde_equivalence_test
May 24, 2026
Merged

blockifier: raw VC serde equivalence test#14130
dorimedini-starkware merged 1 commit into
mainfrom
05-21-blockifier_raw_vc_serde_equivalence_test

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 24, 2026

Artifacts upload workflows:

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Changes are limited to test-only serialization/PartialEq derives and a new round-trip serde test; runtime behavior is unaffected outside test/testing builds.

Overview
Adds test-only serde round-trip coverage for versioned constants by reading each resources/*.json, deserializing into RawVersionedConstants, serializing back to JSON, and asserting the result re-deserializes to the same value.

To support this, expands #[cfg(test|testing)] derives to include Serialize/PartialEq on several raw VC structs/enums and adds custom serialization helpers (notably for VmResourceCosts.builtins and RawOsResources) so the pretty-printed JSON is stable and comparable in tests.

Reviewed by Cursor Bugbot for commit a1cf7a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4afb5f5. Configure here.

Comment thread crates/blockifier/src/versioned_constants_test.rs Outdated
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_raw_vc_serde_equivalence_test branch from 4afb5f5 to a1cf7a7 Compare May 24, 2026 10:15
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 24, 2026
Merged via the queue into main with commit e270b2f May 24, 2026
33 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants