Skip to content

starknet_os: os resources test - measure linear factor, add deploy#14134

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_create_fixed_deployable_accountfrom
05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy
Open

starknet_os: os resources test - measure linear factor, add deploy#14134
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_create_fixed_deployable_accountfrom
05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Changes published syscall gas and OS resource tables plus OS program hashes, which affect fee accounting and proving compatibility if mismatched with network expectations.

Overview
Extends the OS resources regression flow so Deploy is measured like other syscalls instead of being skipped, including base cost and per-calldata linear factor (paired back-to-back deploys in the measurement contract).

The measurement harness now records VariableResourceParams::WithFactor for syscalls with linear input cost (Deploy and MetaTxV0), and writes results into blockifier_versioned_constants_0_14_3.json (Deploy constant steps/Pedersen tweaks). DEPLOY_GAS_COST in OS constants and program_hash.json (os / virtual_os) are bumped to stay aligned with the new deploy overhead.

Reviewed by Cursor Bugbot for commit 9711ff8. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-starknet_os_os_resources_test_-_library_call to graphite-base/14134 May 24, 2026 13:10
@dorimedini-starkware dorimedini-starkware force-pushed the 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy branch from a775a63 to 268457e Compare May 24, 2026 17:03
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 268457e. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy branch from 268457e to 8b293fb Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the graphite-base/14134 branch 2 times, most recently from 6266963 to b45291c Compare May 25, 2026 09:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy branch from 8b293fb to bd9c3be Compare May 25, 2026 09:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy branch from bd9c3be to 9711ff8 Compare May 25, 2026 15:37
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14134 to 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account May 25, 2026 15:37
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).


crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 253 at r3 (raw file):

                    "builtin_instance_counter": {
                        "range_check_builtin": 21,
                        "pedersen_builtin": 8

Should be 7. It's 8 here because your base case is with array![0]...
Maybe do 3 calls? base, linear[1], linear[2]?

Code quote:

 "pedersen_builtin": 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants