starknet_os: os resources test - measure linear factor, add deploy#14134
Conversation
PR SummaryMedium Risk Overview The measurement harness now records Reviewed by Cursor Bugbot for commit 9711ff8. Bugbot is set up for automated code reviews on this repo. Configure here. |
a3596f2 to
ec08192
Compare
311e125 to
a775a63
Compare
ec08192 to
2bd681f
Compare
a775a63 to
268457e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 268457e. Configure here.
268457e to
8b293fb
Compare
6266963 to
b45291c
Compare
8b293fb to
bd9c3be
Compare
bd9c3be to
9711ff8
Compare
b45291c to
91c50c1
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 253 at r3 (raw file):
"builtin_instance_counter": { "range_check_builtin": 21, "pedersen_builtin": 8
Should be 7. It's 8 here because your base case is with array![0]...
Maybe do 3 calls? base, linear[1], linear[2]?
Code quote:
"pedersen_builtin": 8

No description provided.