starknet_os: os resources test - library call#14129
starknet_os: os resources test - library call#14129dorimedini-starkware wants to merge 1 commit into
Conversation
8b1afb6 to
a3596f2
Compare
a5cf1a7 to
c7c8260
Compare
|
Artifacts upload workflows: |
PR SummaryMedium Risk Overview The test contract’s Reviewed by Cursor Bugbot for commit bf48e42. Bugbot is set up for automated code reviews on this repo. Configure here. |
a3596f2 to
ec08192
Compare
c7c8260 to
bd46d55
Compare
ec08192 to
b88d6c1
Compare
bd46d55 to
ae772fc
Compare
ae772fc to
6a1a1c1
Compare
b88d6c1 to
24bc2a4
Compare
24bc2a4 to
7facbbd
Compare
6a1a1c1 to
2dc8f91
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7facbbd. Configure here.
| @@ -1,2 +1,2 @@ | |||
| ~ /enable_casm_hash_migration: true | |||
| + /os_constants/allowed_virtual_os_program_hashes/1: "0x353c95032139e1a1b2159b6550084551652bfef9c0395d2a99aa1e6f2edb26e" | |||
| + /os_constants/allowed_virtual_os_program_hashes/1: "0x4fb8c0cb28349d61091f3fc633493c01385f77cd0d4ebfd577251b3941d49b9" | |||
There was a problem hiding this comment.
Regression diff missing LibraryCall n_steps change
Low Severity
The regression diff file between 0.14.2 and 0.14.3 was updated to reflect the new allowed_virtual_os_program_hashes value, but it's missing the LibraryCall n_steps change from 879 (in 0.14.2) to 872 (in 0.14.3). This omission means the regression diff file no longer accurately captures all differences between the two versions, which will likely cause the associated regression test to fail.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7facbbd. Configure here.
There was a problem hiding this comment.
The CI is green, how can it be @dorimedini-starkware?
7facbbd to
bf48e42
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
| @@ -1,2 +1,2 @@ | |||
| ~ /enable_casm_hash_migration: true | |||
| + /os_constants/allowed_virtual_os_program_hashes/1: "0x353c95032139e1a1b2159b6550084551652bfef9c0395d2a99aa1e6f2edb26e" | |||
| + /os_constants/allowed_virtual_os_program_hashes/1: "0x4fb8c0cb28349d61091f3fc633493c01385f77cd0d4ebfd577251b3941d49b9" | |||
There was a problem hiding this comment.
The CI is green, how can it be @dorimedini-starkware?
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).



No description provided.