Skip to content

starknet_os: initial test, measure call contract resources#14128

Open
dorimedini-starkware wants to merge 1 commit into
mainfrom
05-21-starknet_os_initial_test_measure_call_contract_resources
Open

starknet_os: initial test, measure call contract resources#14128
dorimedini-starkware wants to merge 1 commit into
mainfrom
05-21-starknet_os_initial_test_measure_call_contract_resources

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 21, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-starknet_os_add_os_logger_to_runner_output_for_tests to graphite-base/14128 May 21, 2026 13:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch 2 times, most recently from fc51ad3 to 6a4dbd9 Compare May 21, 2026 13:49
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 6a4dbd9 to a5cf1a7 Compare May 21, 2026 14:03
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14128 to 05-21-blockifier_test_utils_add_os_resources_measurement_contract May 21, 2026 14:03
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from a5cf1a7 to c7c8260 Compare May 24, 2026 06:50
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch 2 times, most recently from bd46d55 to 7a5baea Compare May 24, 2026 11:41
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_test_utils_add_os_resources_measurement_contract branch from 26755a8 to 717e243 Compare May 24, 2026 11:41
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 7a5baea to f589d68 Compare May 24, 2026 12:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_test_utils_add_os_resources_measurement_contract branch 2 times, most recently from 599963c to b3e44b0 Compare May 24, 2026 13:12
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch 2 times, most recently from ae772fc to 6a1a1c1 Compare May 24, 2026 17:03
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-blockifier_test_utils_add_os_resources_measurement_contract branch from b3e44b0 to 92daa01 Compare May 24, 2026 17:03
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 6a1a1c1 to 2dc8f91 Compare May 25, 2026 09:48
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 10 files and all commit messages, and made 2 comments.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).


crates/starknet_os_flow_tests/src/os_resources_test.rs line 161 at r2 (raw file):

            // iterator.
            let inner_overhead = if selector.is_calling_syscall() {
                inner_calls_iter.next().unwrap().resources.vm_resources

Add a TODO to account for opcodes as well (e.g. blake)
This will be relevant once we move from pedersen

Code quote:

inner_calls_iter.next().unwrap().resources.vm_resources

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yoni-Starkware).


crates/starknet_os_flow_tests/src/os_resources_test.rs line 161 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Add a TODO to account for opcodes as well (e.g. blake)
This will be relevant once we move from pedersen

can you explain why the TODO should be in the inner_calls area?

@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-blockifier_test_utils_add_os_resources_measurement_contract to graphite-base/14128 May 25, 2026 15:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 2dc8f91 to 12e7d75 Compare May 25, 2026 15:37
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14128 to main May 25, 2026 15:37
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 12e7d75. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 12e7d75 to 4c52ab5 Compare May 25, 2026 15:56
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 4c52ab5 to 1cba9ca Compare May 25, 2026 16:02
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 6 of 16 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and Yoni-Starkware).


crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 130 at r4 (raw file):

        "allowed_virtual_os_program_hashes": [
            "0x3e98c2d7703b03a7edb73ed7f075f97f1dcbaa8f717cdf6e1a57bf058265473",
            "0xbec09f34635cc1590c9d8a0f53f9fc198a4b57f4f832e7e22a4e55946eab21"

should I append this or replace the 0x353.. hash? @Yoni-Starkware

Code quote:

"0xbec09f34635cc1590c9d8a0f53f9fc198a4b57f4f832e7e22a4e55946eab21"

Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 10 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).


crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 130 at r4 (raw file):

Previously, dorimedini-starkware wrote…

should I append this or replace the 0x353.. hash? @Yoni-Starkware

Replace. The second one is the pending hash of v0.14.3.


crates/starknet_os_flow_tests/src/os_resources_test.rs line 161 at r2 (raw file):

Previously, dorimedini-starkware wrote…

can you explain why the TODO should be in the inner_calls area?

I see you work here with ExecutionResources and not ExtendedExecutionResources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants