starknet_os: initial test, measure call contract resources#14128
starknet_os: initial test, measure call contract resources#14128dorimedini-starkware wants to merge 1 commit into
Conversation
c3c76fd to
9b22fec
Compare
fc51ad3 to
6a4dbd9
Compare
9b22fec to
1e1aa17
Compare
6a4dbd9 to
a5cf1a7
Compare
a5cf1a7 to
c7c8260
Compare
bd46d55 to
7a5baea
Compare
26755a8 to
717e243
Compare
7a5baea to
f589d68
Compare
599963c to
b3e44b0
Compare
ae772fc to
6a1a1c1
Compare
b3e44b0 to
92daa01
Compare
6a1a1c1 to
2dc8f91
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 10 files and all commit messages, and made 2 comments.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
crates/starknet_os_flow_tests/src/os_resources_test.rs line 161 at r2 (raw file):
// iterator. let inner_overhead = if selector.is_calling_syscall() { inner_calls_iter.next().unwrap().resources.vm_resources
Add a TODO to account for opcodes as well (e.g. blake)
This will be relevant once we move from pedersen
Code quote:
inner_calls_iter.next().unwrap().resources.vm_resources
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yoni-Starkware).
crates/starknet_os_flow_tests/src/os_resources_test.rs line 161 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Add a TODO to account for opcodes as well (e.g. blake)
This will be relevant once we move from pedersen
can you explain why the TODO should be in the inner_calls area?
92daa01 to
7ca8faf
Compare
2dc8f91 to
12e7d75
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 12e7d75. Configure here.
12e7d75 to
4c52ab5
Compare
4c52ab5 to
1cba9ca
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 6 of 16 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and Yoni-Starkware).
crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 130 at r4 (raw file):
"allowed_virtual_os_program_hashes": [ "0x3e98c2d7703b03a7edb73ed7f075f97f1dcbaa8f717cdf6e1a57bf058265473", "0xbec09f34635cc1590c9d8a0f53f9fc198a4b57f4f832e7e22a4e55946eab21"
should I append this or replace the 0x353.. hash? @Yoni-Starkware
Code quote:
"0xbec09f34635cc1590c9d8a0f53f9fc198a4b57f4f832e7e22a4e55946eab21"
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 10 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).
crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 130 at r4 (raw file):
Previously, dorimedini-starkware wrote…
should I append this or replace the
0x353..hash? @Yoni-Starkware
Replace. The second one is the pending hash of v0.14.3.
crates/starknet_os_flow_tests/src/os_resources_test.rs line 161 at r2 (raw file):
Previously, dorimedini-starkware wrote…
can you explain why the TODO should be in the inner_calls area?
I see you work here with ExecutionResources and not ExtendedExecutionResources


No description provided.