Skip to content

starknet_os: os resources test - add secp syscalls#14144

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1from
05-23-starknet_os_os_resources_test_-_add_secp_syscalls
Open

starknet_os: os resources test - add secp syscalls#14144
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1from
05-23-starknet_os_os_resources_test_-_add_secp_syscalls

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown

Artifacts upload workflows:

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 24, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 24, 2026 07:03
@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Updates network fee-related secp syscall gas and OS resource tables plus OS program hashes; changes are mostly cost reductions aligned with measurement but affect billing and proving identity.

Overview
This PR wires secp256k1 and secp256r1 syscalls into the OS resources regression path so their VM step costs are measured from a real __execute__ run instead of being skipped as “unmeasurable.”

The OsResourcesTestContract now exercises each secp syscall (new, add, get point from x, get xy, mul) for both curves. The flow test drops those selectors from UNMEASURABLE_SYSCALLS and treats Secp256k1New / Secp256r1New as syscalls that may appear twice in the trace (second occurrence is ignored when building per-syscall measurements).

Measured costs are written through to blockifier_versioned_constants_0_14_3.json (n_steps for each Secp* entry, mostly slightly lower) and matching SECP*_GAS_COST values in OS constants.cairo. program_hash.json is updated for the rebuilt OS / virtual OS hashes.

Reviewed by Cursor Bugbot for commit ac5afa2. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from 39edd2e to b4dc505 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from f5a424e to ac5afa2 Compare May 24, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants