Skip to content

starknet_transaction_prover: add --log-format text|json CLI flag#14162

Merged
avi-starkware merged 1 commit into
mainfrom
avi/prover-v3/log-format
May 25, 2026
Merged

starknet_transaction_prover: add --log-format text|json CLI flag#14162
avi-starkware merged 1 commit into
mainfrom
avi/prover-v3/log-format

Conversation

@avi-starkware
Copy link
Copy Markdown
Collaborator

@avi-starkware avi-starkware commented May 24, 2026

starknet_transaction_prover: add --log-format text|json CLI flag

Adds a LogFormat enum and --log-format / LOG_FORMAT=text|json
selector that switches the tracing subscriber between the text and JSON
formatters. Default is text. Matches the discovery-service convention.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Adds a LogFormat enum and `--log-format` / `LOG_FORMAT=text|json`
selector that switches the tracing subscriber between the text and JSON
formatters. Default is text. Matches the discovery-service convention.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Observability-only change to log formatting at startup; no proving, RPC, or security behavior is modified.

Overview
Adds a --log-format / LOG_FORMAT switch (text | json, default text) on the Starknet transaction prover so operators can emit structured JSON logs for aggregators without changing the existing RUST_LOG filter defaults.

Startup now parses CLI args before initializing tracing_subscriber, then picks either the plain text or .json() fmt layer from the new LogFormat enum. Config tests were updated so synthetic CliArgs include the default text format.

Reviewed by Cursor Bugbot for commit c219d32. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor

@einat-starkware einat-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@einat-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on avi-starkware).

@avi-starkware avi-starkware added this pull request to the merge queue May 25, 2026
Merged via the queue into main with commit 453dcc9 May 25, 2026
53 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants