Skip to content

apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob#13985

Merged
ShahakShama merged 2 commits into
mainfrom
05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob
May 24, 2026
Merged

apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob#13985
ShahakShama merged 2 commits into
mainfrom
05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 6, 2026

PR Summary

Medium Risk
Changes the cende blob wire format by adding a new fee_proposal_info object that must stay schema-compatible with the centralized Python recorder; mismatches could break blob ingestion, but the change is additive and optional (None for older blocks).

Overview
Adds SNIP-35 proposer-stated fee data to the cende/Aerospike blob by introducing FeeProposalInfo { fee_proposal_fri: Option<GasPrice> } and wiring it through BlobParameters and AerospikeBlob serialization.

Updates consensus-to-cende plumbing to forward init.fee_proposal_fri, refreshes golden JSON fixtures/regression generation, and adds serde tests to lock the cross-language JSON field name/shape.

Reviewed by Cursor Bugbot for commit 242ba37. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 13055bc to f4453fd Compare May 6, 2026 12:00
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 81d0db6 to a5a97ee Compare May 6, 2026 12:00
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from f4453fd to d71ccfb Compare May 8, 2026 12:36
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from a5a97ee to b8bc905 Compare May 8, 2026 12:36
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from d71ccfb to 48084df Compare May 10, 2026 09:02
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 7c4b8ed to 79d2b12 Compare May 20, 2026 13:45
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 4984c24 to 9669cde Compare May 20, 2026 21:15
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 79d2b12 to 8f49ac7 Compare May 20, 2026 21:15
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 9669cde to b9d80d1 Compare May 20, 2026 21:16
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 8f49ac7 to bb6768b Compare May 20, 2026 21:16
@ShahakShama ShahakShama force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from b9d80d1 to b49ef3d Compare May 24, 2026 08:27
@ShahakShama ShahakShama force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from bb6768b to b68b8f9 Compare May 24, 2026 08:27
@ShahakShama ShahakShama force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from b49ef3d to 5b171a5 Compare May 24, 2026 10:39
@ShahakShama ShahakShama force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from b68b8f9 to 0716294 Compare May 24, 2026 10:39
@sirandreww-starkware sirandreww-starkware changed the base branch from 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal to main May 24, 2026 11:20
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 0716294 to 9522d0e Compare May 24, 2026 11:20
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 24, 2026

Merge activity

  • May 24, 11:21 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@ShahakShama ShahakShama force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch 2 times, most recently from e233adf to 6462db4 Compare May 24, 2026 12:49
@ShahakShama ShahakShama force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 6462db4 to 242ba37 Compare May 24, 2026 12:50
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 5 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants