Skip to content

apollo_consensus_manager: wire STRK/USD oracle into consensus manager#13820

Closed
sirandreww-starkware wants to merge 1 commit into
04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validationfrom
04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager
Closed

apollo_consensus_manager: wire STRK/USD oracle into consensus manager#13820
sirandreww-starkware wants to merge 1 commit into
04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validationfrom
04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

This was referenced Apr 19, 2026
@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from 6bd60bb to 8020f60 Compare April 19, 2026 17:43
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from cfa6f7a to 10c280c Compare April 19, 2026 17:43
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from 8020f60 to c410076 Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from 10c280c to 209889b Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from 74f5e86 to 02d9331 Compare May 3, 2026 07:17
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13820 to 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation May 3, 2026 07:17
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from 9fb345e to dcf0feb Compare May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from 02d9331 to aee5c5f Compare May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from aee5c5f to 7d97bbf Compare May 3, 2026 13:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from dcf0feb to 4ddb820 Compare May 3, 2026 13:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from 7d97bbf to b401ce7 Compare May 3, 2026 14:34
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch from 4ddb820 to 436ef14 Compare May 3, 2026 14:34
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_manager_wire_strk_usd_oracle_into_consensus_manager branch from b401ce7 to f60926c Compare May 4, 2026 07:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_proposal_validation branch 2 times, most recently from b4e3014 to 683d6d0 Compare May 4, 2026 11:14
Comment thread crates/apollo_consensus_manager/src/consensus_manager.rs
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8e1345e. Configure here.

// (safe but static).
strk_to_usd_oracle: Some(Arc::new(ExchangeRateOracleClient::new(
apollo_l1_gas_price_config::config::ExchangeRateOracleConfig::default(),
))),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded default config degrades behavior versus previous None

Medium Severity

Switching strk_to_usd_oracle from None to Some(...) with an unconfigurable ExchangeRateOracleConfig::default() (placeholder URL api.example.com, lag_interval_seconds: 1) produces strictly worse behavior than None. The TODO comment says "deployments must override url_header_list via their config overlay" but no config path exists to do so — the config is hardcoded. Every block proposal now spawns HTTP requests to api.example.com, emits warn!-level log spam (previously debug! with None), and the functional result is identical: fee_proposal freezes at fee_actual.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8e1345e. Configure here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants