apollo_consensus_manager: wire STRK/USD oracle into consensus manager#13820
Conversation
6bd60bb to
8020f60
Compare
cfa6f7a to
10c280c
Compare
8020f60 to
c410076
Compare
10c280c to
209889b
Compare
74f5e86 to
02d9331
Compare
9fb345e to
dcf0feb
Compare
02d9331 to
aee5c5f
Compare
aee5c5f to
7d97bbf
Compare
dcf0feb to
4ddb820
Compare
7d97bbf to
b401ce7
Compare
4ddb820 to
436ef14
Compare
b401ce7 to
f60926c
Compare
b4e3014 to
683d6d0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8e1345e. Configure here.
| // (safe but static). | ||
| strk_to_usd_oracle: Some(Arc::new(ExchangeRateOracleClient::new( | ||
| apollo_l1_gas_price_config::config::ExchangeRateOracleConfig::default(), | ||
| ))), |
There was a problem hiding this comment.
Hardcoded default config degrades behavior versus previous None
Medium Severity
Switching strk_to_usd_oracle from None to Some(...) with an unconfigurable ExchangeRateOracleConfig::default() (placeholder URL api.example.com, lag_interval_seconds: 1) produces strictly worse behavior than None. The TODO comment says "deployments must override url_header_list via their config overlay" but no config path exists to do so — the config is hardcoded. Every block proposal now spawns HTTP requests to api.example.com, emits warn!-level log spam (previously debug! with None), and the functional result is identical: fee_proposal freezes at fee_actual.
Reviewed by Cursor Bugbot for commit 8e1345e. Configure here.



No description provided.