apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation

[sirandreww-starkware]

No description provided.

[sirandreww-starkware]

• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819 : 2 dependent PRs (#13820 , #14157 ) 👈 (View in Graphite)
• apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash #13949
• apollo_starknet_client: read fee_proposal_fri from feeder gateway #13986
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob #13985
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818
• apollo_consensus_orchestrator,apollo_consensus_manager: move SNIP-35 bootstrap to pre-consensus #14061
• apollo_node_config: made validation only node hold full state #14122
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[ShahakShama]

@ShahakShama reviewed 4 files and all commit messages, and made 5 comments.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on sirandreww-starkware).

---

crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs line 837 at r2 (raw file):

                        .unwrap_or(self.l2_gas_price),
                    starknet_version: StarknetVersion::LATEST,
                    fee_actual: compute_fee_actual(&self.fee_proposals_window, init.height),

Why do you need to compute fee actual? What you need to compute is fee_actual_min and fee_actual_max

---

crates/apollo_consensus_orchestrator/src/test_utils.rs line 429 at r2 (raw file):

        starknet_version: starknet_api::block::StarknetVersion::LATEST,
        version_constant_commitment: Default::default(),
        // SNIP-35: required because LATEST >= V0_14_3. Match the proposer's default-fallback

No need for such a long comment. Just write the start:
// SNIP-35: required because LATEST >= V0_14_3. Match the proposer's default-fallback
// fee_proposal

---

crates/apollo_consensus_orchestrator/src/validate_proposal.rs line 81 at r2 (raw file):

    pub l2_gas_price_fri: GasPrice,
    pub starknet_version: StarknetVersion,
    /// SNIP-35: fee_actual from the sliding window. `None` during initiation, before the window

initiation's meaning is unclear

---

crates/apollo_consensus_orchestrator/src/validate_proposal.rs line 379 at r2 (raw file):

    }

    // SNIP-35: validate fee_proposal is within the configured margin of fee_actual.

As I said before, you shouldn't calculate margin from the fee actual you think should be based on your oracle. You should look at the max and min allowed

---

crates/apollo_consensus_orchestrator/src/validate_proposal_test.rs line 107 at r2 (raw file):

        l2_gas_price_fri: VersionedConstants::latest_constants().min_gas_price,
        starknet_version: StarknetVersion::LATEST,
        fee_actual: None,

Add TODO to test Some

[ShahakShama]

@ShahakShama resolved 3 discussions.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on sirandreww-starkware).

[sirandreww-starkware]

@sirandreww-starkware made 2 comments.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on ShahakShama).

---

crates/apollo_consensus_orchestrator/src/validate_proposal.rs line 81 at r2 (raw file):

Previously, ShahakShama wrote…

initiation's meaning is unclear

Done

---

crates/apollo_consensus_orchestrator/src/validate_proposal_test.rs line 107 at r2 (raw file):

Previously, ShahakShama wrote…

Add TODO to test Some

added a test instead of a TODO

[ShahakShama]

@ShahakShama reviewed 4 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).