Skip to content

apollo_starknet_client: read fee_proposal_fri from feeder gateway#13986

Merged
sirandreww-starkware merged 2 commits into
mainfrom
05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway
May 25, 2026
Merged

apollo_starknet_client: read fee_proposal_fri from feeder gateway#13986
sirandreww-starkware merged 2 commits into
mainfrom
05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 6, 2026

PR Summary

Medium Risk
Changes block fetch URLs and header fields used when syncing blocks; malformed-request fallback limits rollout risk but fee header correctness affects downstream consensus/fee logic.

Overview
Adds support for SNIP-35 proposer fee data from the Starknet feeder gateway: block fetches now request withFeeProposalInfo=true (alongside existing withFeeMarketInfo), with a temporary retry without that query param when the gateway returns MalformedRequest (pre-0.14.3 compatibility).

BlockPostV0_13_1 gains optional fee_proposal_fri; conversion to starknet_api block headers now passes it through instead of always setting None. A new block_post_0_14_3.json fixture and tests cover parsing, backward compatibility with 0.14.2 fixtures, and header propagation.

Reviewed by Cursor Bugbot for commit 120c7b3. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 13055bc to f4453fd Compare May 6, 2026 12:00
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch from 7a517f4 to 1292e67 Compare May 6, 2026 12:00
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from f4453fd to d71ccfb Compare May 8, 2026 12:36
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch 2 times, most recently from 058ffbf to 4fd3d44 Compare May 10, 2026 09:02
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch from 67d7df4 to cabbd28 Compare May 20, 2026 21:15
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 79d2b12 to 8f49ac7 Compare May 20, 2026 21:15
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 8f49ac7 to bb6768b Compare May 20, 2026 21:16
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch from cabbd28 to 1aa19b1 Compare May 20, 2026 21:16
@ShahakShama ShahakShama force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from bb6768b to b68b8f9 Compare May 24, 2026 08:27
@ShahakShama ShahakShama force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch 2 times, most recently from 69a3ee0 to 6a16c88 Compare May 24, 2026 10:39
@ShahakShama ShahakShama force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from b68b8f9 to 0716294 Compare May 24, 2026 10:39
@graphite-app graphite-app Bot changed the base branch from 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob to graphite-base/13986 May 24, 2026 11:20
@ShahakShama ShahakShama force-pushed the graphite-base/13986 branch from 0716294 to e233adf Compare May 24, 2026 11:41
@ShahakShama ShahakShama force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch from 6a16c88 to 6f6c603 Compare May 24, 2026 11:41
@ShahakShama ShahakShama changed the base branch from graphite-base/13986 to 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob May 24, 2026 11:41
@ShahakShama ShahakShama changed the base branch from 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob to graphite-base/13986 May 24, 2026 12:48
@ShahakShama ShahakShama force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch from 794dc59 to ba09fea Compare May 24, 2026 12:50
@ShahakShama ShahakShama force-pushed the graphite-base/13986 branch from e233adf to 242ba37 Compare May 24, 2026 12:50
@ShahakShama ShahakShama changed the base branch from graphite-base/13986 to 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob May 24, 2026 12:51
@sirandreww-starkware sirandreww-starkware changed the base branch from 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob to main May 24, 2026 13:46
@ShahakShama ShahakShama force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch from ba09fea to 24591ff Compare May 24, 2026 13:47
@ShahakShama ShahakShama force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch from 24591ff to 120c7b3 Compare May 25, 2026 06:19
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants