apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash

[sirandreww-starkware]

No description provided.

[sirandreww-starkware]

• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819 : 2 dependent PRs (#13820 , #14157 )
• apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash #13949 👈 (View in Graphite)
• apollo_starknet_client: read fee_proposal_fri from feeder gateway #13986
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob #13985
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818
• apollo_consensus_orchestrator,apollo_consensus_manager: move SNIP-35 bootstrap to pre-consensus #14061
• apollo_node_config: made validation only node hold full state #14122
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[cursor]

PR Summary

High Risk
Changes the consensus commitment identity validators and reproposals depend on; a mismatch on fee_proposal between proposer and validator would reject otherwise valid blocks.

Overview
SNIP-35 proposal commitments now mix in the proposer’s fee_proposal_fri instead of using only the batcher’s partial block hash. A shared helper proposal_commitment_from in snip35 returns the legacy hash when fee_proposal is None (pre-V0_14_3) and Poseidon(partial, fee_proposal_fri) when it is set, so consensus cannot agree on one fee in ProposalInit and another in the signed commitment.

Build, validate, and stored proposals all use the same rule: the proposer passes its computed fee; the validator uses init.fee_proposal_fri when finishing validation; BuiltProposals::insert_proposal hashes with the init’s fee. Cende blob wiring maps parent commitments through the same helper (parent fee still None with a TODO). Tests and proposal_init / send_proposal_to_validator_context were updated so default expectations use 8 gwei and the matching Poseidon commitment.

^{Reviewed by Cursor Bugbot for commit b5155ff. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5da3ec4. Configure here.}

[ShahakShama]

@ShahakShama reviewed 8 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on matanl-starkware and sirandreww-starkware).

---

a discussion (no related file):
@matanl-starkware should review as well

---

crates/apollo_consensus_orchestrator/src/test_utils.rs line 434 at r4 (raw file):

        // helper to fabricate an init that matches what the proposer emits, so proposer and
        // validator agree on the proposal commitment hash.
        fee_proposal_fri: Some(GasPrice(8_000_000_000)),

Extract 8000000000 to a constant

[matanl-starkware]

@matanl-starkware reviewed 8 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on sirandreww-starkware).

[ShahakShama]

@ShahakShama reviewed 3 files and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

[ShahakShama]

@ShahakShama resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).