Skip to content

apollo_dashboard: add SNIP-35 row#13954

Merged
sirandreww-starkware merged 1 commit into
mainfrom
05-04-apollo_dashboard_add_snip-35_row
May 14, 2026
Merged

apollo_dashboard: add SNIP-35 row#13954
sirandreww-starkware merged 1 commit into
mainfrom
05-04-apollo_dashboard_add_snip-35_row

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented May 4, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 4, 2026

PR Summary

Low Risk
Low risk: dashboard-only changes that add new panels/queries without altering runtime behavior or data paths.

Overview
Adds a new SNIP-35 row to the Apollo Grafana dashboard, exposing time-series panels for snip35_fee_actual, snip35_fee_proposal, snip35_fee_target (scaled to GFri) and snip35_strk_usd_rate (scaled to USD).

Wires the row into get_apollo_dashboard() and updates dev_grafana.json so the generated/checked-in dashboard includes the new section.

Reviewed by Cursor Bugbot for commit 61cc1c9. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from 095dd65 to f5e6b88 Compare May 4, 2026 13:20
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from adfcffc to 989d6b3 Compare May 4, 2026 13:20
@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from f5e6b88 to ecce043 Compare May 5, 2026 06:53
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).


crates/apollo_dashboard/src/dashboard_definitions.rs line 93 at r1 (raw file):

            get_consensus_row(),
            get_consensus_streams_row(),
            get_snip35_row(),

Put this below l1_gas_price_row

@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from ecce043 to a5edb13 Compare May 5, 2026 13:13
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 4ce566a to 964596f Compare May 5, 2026 13:13
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on ShahakShama).


crates/apollo_dashboard/src/dashboard_definitions.rs line 93 at r1 (raw file):

Previously, ShahakShama wrote…

Put this below l1_gas_price_row

Done.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 964596f to edb1b57 Compare May 6, 2026 06:29
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d341bc0. Configure here.

Comment thread crates/apollo_dashboard/resources/dev_grafana.json Outdated
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from edb1b57 to 77f5bbd Compare May 6, 2026 10:28
@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from d341bc0 to 209731c Compare May 6, 2026 10:28
@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch 2 times, most recently from 354cf9c to ec16cd6 Compare May 8, 2026 12:36
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 6bbf0dd to f93b2ca Compare May 10, 2026 09:02
@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch 2 times, most recently from 312819a to a9cbd37 Compare May 10, 2026 09:07
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from f93b2ca to 206a807 Compare May 10, 2026 09:07
@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from a9cbd37 to ea9fb4f Compare May 10, 2026 12:15
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 206a807 to 8f71fe7 Compare May 10, 2026 12:16
@graphite-app graphite-app Bot changed the base branch from 04-19-apollo_consensus_orchestrator_add_snip-35_metrics to graphite-base/13954 May 11, 2026 07:13
@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from ea9fb4f to c458957 Compare May 11, 2026 12:57
@graphite-app graphite-app Bot changed the base branch from graphite-base/13954 to main May 11, 2026 12:57
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 11, 2026

Merge activity

  • May 11, 12:57 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from c458957 to 61cc1c9 Compare May 14, 2026 07:00
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit 7de09fd May 14, 2026
16 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants