apollo_l1_gas_price: hold strk_to_usd oracle client + strk_to_usd_rate

[ShahakShama]

Goal: PR 2 of 6 in the stack moving the STRK/USD oracle from the
ad-hoc wiring in SequencerConsensusContext into L1GasPriceProvider.
This commit adds the field and inherent method on the provider but
nothing calls it yet — the seam is established without behavior
change.

Change summary:

• L1GasPriceProvider gains a second Arc<dyn ExchangeRateOracleClientTrait>
  field (strk_to_usd_oracle_client), positionally after the existing
  eth_to_strk_oracle_client.
• new takes a second oracle client parameter.
• new_with_oracle reads config.strk_to_usd_oracle_config (added in
  the previous commit on this stack) and constructs the client.
• New inherent method strk_to_usd_rate(timestamp) mirrors the
  existing eth_to_fri_rate.
• Unit tests in l1_gas_price_provider_test.rs updated to pass a
  second mock to the constructor.

Decision points:

• Positional constructor argument over a builder. The struct has two
  oracle clients now; if a third lands later, builder pattern is the
  right move. For two, positional is fine.
• Same ExchangeRateOracleClientError propagation via the existing
  L1GasPriceProviderError::ExchangeRateOracleClientError variant.
  No new error variant needed — the two oracles are semantically
  identical, only differ by URL.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

[cursor]

PR Summary

Low Risk
Constructor/API extension and unused method; no new call sites or pricing logic changes in this commit.

Overview
L1GasPriceProvider now owns a second exchange-rate oracle (strk_to_usd_oracle_client) alongside the existing ETH→STRK client, wired from config.strk_to_usd_oracle_config in new_with_oracle with STRK_TO_USD_ORACLE_METRICS.

new takes an extra Arc<dyn ExchangeRateOracleClientTrait> argument, and a new strk_to_usd_rate(timestamp) method mirrors eth_to_fri_rate (same error mapping). Unit tests pass a second mock into the constructor.

Nothing in this diff calls strk_to_usd_rate yet—this establishes the seam for later stack PRs to move STRK/USD fetching off ad-hoc sequencer wiring.

^{Reviewed by Cursor Bugbot for commit dc3f241. Bugbot is set up for automated code reviews on this repo. Configure here.}

[reviewable-StarkWare]

This change is 

[ShahakShama]

• apollo_consensus_orchestrator: add SNIP-35 integration TODO doc #13982
• apollo_consensus_orchestrator: tmp dirty tests for SNIP-35 (NOT FOR MERGE) #13857
• apollo_l1_gas_price,apollo_l1_gas_price_config: move exchange_rate_decimals const to config #13881
• apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests #13856
• apollo_consensus_orchestrator: add SNIP-35 module edge case tests #13855
• apollo_consensus_orchestrator,apollo_consensus_manager: route STRK/USD via L1GasPriceProvider #14161
• apollo_integration_tests,apollo_deployments: prime strk_to_usd_oracle overlays #14160
• apollo_l1_gas_price_types,apollo_l1_gas_price: expose get_strk_to_usd_rate #14159
• apollo_l1_gas_price: hold strk_to_usd oracle client + strk_to_usd_rate #14158 👈 (View in Graphite)
• apollo_l1_gas_price: parameterize ExchangeRateOracleClient by metric set #14199
• apollo_l1_gas_price_config,apollo_node: add strk_to_usd_oracle_config #14157
• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819 : 1 other dependent PR (#13820 )
• apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash #13949
• apollo_starknet_client: read fee_proposal_fri from feeder gateway #13986
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob #13985
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818
• apollo_consensus_orchestrator,apollo_consensus_manager: move SNIP-35 bootstrap to pre-consensus #14061
• apollo_node_config: made validation only node hold full state #14122
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 2819fb7. Configure here.}

[matanl-starkware]

@matanl-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).

[matanl-starkware]

@matanl-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

[sirandreww-starkware]

@sirandreww-starkware made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

[graphite-app]

Merge activity

• May 26, 1:58 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.