Skip to content

apollo_consensus_orchestrator: add SNIP-35 metrics#13816

Merged
sirandreww-starkware merged 1 commit into
mainfrom
04-19-apollo_consensus_orchestrator_add_snip-35_metrics
May 11, 2026
Merged

apollo_consensus_orchestrator: add SNIP-35 metrics#13816
sirandreww-starkware merged 1 commit into
mainfrom
04-19-apollo_consensus_orchestrator_add_snip-35_metrics

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 19, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from e3b70b5 to 96249ec Compare April 19, 2026 17:43
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from f24886f to f42b483 Compare April 19, 2026 17:43
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from f42b483 to afa631a Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 96249ec to 88a4a65 Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 0e781a5 to fce08ea Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from 0fdd676 to d28c88a Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from fce08ea to d5dcc22 Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from 47c092a to d259d42 Compare May 1, 2026 15:44
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from d5dcc22 to 7444e75 Compare May 1, 2026 15:44
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from d259d42 to 67f8dd0 Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 7444e75 to 03322f6 Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from 67f8dd0 to c73832d Compare May 1, 2026 17:05
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch 2 times, most recently from 28a1b63 to 37268dc Compare May 3, 2026 07:01
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from c73832d to 4209e5f Compare May 3, 2026 07:01
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).


a discussion (no related file):
What about adding to grafana as a row? IMO it should be a separate row

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from 4209e5f to f6b6e1b Compare May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 37268dc to 6eaed45 Compare May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from f6b6e1b to 50f8d9e Compare May 3, 2026 13:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 6eaed45 to 32fafbd Compare May 3, 2026 13:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from 50f8d9e to bd54653 Compare May 3, 2026 14:34
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 32fafbd to 04ed0d0 Compare May 3, 2026 14:34
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_fee_market_functions_and_tests branch from bd54653 to 8726144 Compare May 4, 2026 07:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 04ed0d0 to a488daa Compare May 4, 2026 07:11
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).


a discussion (no related file):

Previously, ShahakShama wrote…

What about adding to grafana as a row? IMO it should be a separate row

Addressed in a follow-up PR above this one in the stack (05-04-apollo_dashboard_add_snip-35_row, #13954). Added a dedicated SNIP-35 row in dashboard_definitions.rs with four panels (fee_actual, fee_proposal, fee_target in GFri; STRK/USD rate in USD), and regenerated dev_grafana.json

Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 11, 2026

Merge activity

  • May 11, 7:14 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants