apollo_consensus_orchestrator: add SNIP-35 metrics#13816
Conversation
e3b70b5 to
96249ec
Compare
f24886f to
f42b483
Compare
f42b483 to
afa631a
Compare
96249ec to
88a4a65
Compare
0e781a5 to
fce08ea
Compare
0fdd676 to
d28c88a
Compare
fce08ea to
d5dcc22
Compare
47c092a to
d259d42
Compare
d5dcc22 to
7444e75
Compare
d259d42 to
67f8dd0
Compare
7444e75 to
03322f6
Compare
67f8dd0 to
c73832d
Compare
28a1b63 to
37268dc
Compare
c73832d to
4209e5f
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).
a discussion (no related file):
What about adding to grafana as a row? IMO it should be a separate row
4209e5f to
f6b6e1b
Compare
37268dc to
6eaed45
Compare
f6b6e1b to
50f8d9e
Compare
6eaed45 to
32fafbd
Compare
50f8d9e to
bd54653
Compare
32fafbd to
04ed0d0
Compare
bd54653 to
8726144
Compare
04ed0d0 to
a488daa
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ShahakShama).
a discussion (no related file):
Previously, ShahakShama wrote…
What about adding to grafana as a row? IMO it should be a separate row
Addressed in a follow-up PR above this one in the stack (05-04-apollo_dashboard_add_snip-35_row, #13954). Added a dedicated SNIP-35 row in dashboard_definitions.rs with four panels (fee_actual, fee_proposal, fee_target in GFri; STRK/USD rate in USD), and regenerated dev_grafana.json
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama made 1 comment and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).
Merge activity
|

No description provided.