Skip to content

apollo_node_config: made validation only node hold full state#14122

Merged
ShahakShama merged 2 commits into
mainfrom
05-20-apollo_node_config_made_validation_only_node_hold_full_state
May 24, 2026
Merged

apollo_node_config: made validation only node hold full state#14122
ShahakShama merged 2 commits into
mainfrom
05-20-apollo_node_config_made_validation_only_node_hold_full_state

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware self-assigned this May 20, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review May 20, 2026 20:57
@cursor
Copy link
Copy Markdown

cursor Bot commented May 20, 2026

PR Summary

Medium Risk
Relaxes a cross-config validation and test defaults so validation-only nodes can use StorageScope::FullArchive, which may increase storage/IO and could mask misconfigurations once StateOnly becomes required again.

Overview
Validation-only nodes are no longer required to use StorageScope::StateOnly for state sync. SequencerNodeConfig::validate_validation_only_config drops the storage-scope check (now a TODO), allowing validation-only configs to keep full state.

Integration-test config generation stops overriding state sync storage scope when validation_only=true, and node-config tests are updated to use a full-archive state sync helper and remove the test that previously asserted full-archive fails in validation-only mode.

Reviewed by Cursor Bugbot for commit 8b5ec15. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-20-apollo_node_config_made_validation_only_node_hold_full_state branch from 0eeb5b1 to 3772cef Compare May 20, 2026 21:16
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on asaf-sw).

@ShahakShama ShahakShama enabled auto-merge May 24, 2026 05:42
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 03b2fb5. Configure here.

Comment thread crates/apollo_node_config/src/config_test.rs Outdated
@ShahakShama ShahakShama force-pushed the 05-20-apollo_node_config_made_validation_only_node_hold_full_state branch from 03b2fb5 to 8b5ec15 Compare May 24, 2026 06:24
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on asaf-sw).

@ShahakShama ShahakShama disabled auto-merge May 24, 2026 07:31
@ShahakShama ShahakShama added this pull request to the merge queue May 24, 2026
@ShahakShama ShahakShama removed this pull request from the merge queue due to a manual request May 24, 2026
@ShahakShama ShahakShama added this pull request to the merge queue May 24, 2026
@ShahakShama ShahakShama removed this pull request from the merge queue due to a manual request May 24, 2026
@ShahakShama ShahakShama added this pull request to the merge queue May 24, 2026
Merged via the queue into main with commit 2ca5cb4 May 24, 2026
24 of 27 checks passed
Copy link
Copy Markdown
Contributor

@asaf-sw asaf-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@asaf-sw made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants