apollo_consensus_orchestrator: tmp dirty tests for SNIP-35 (NOT FOR MERGE)

[sirandreww-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_consensus_orchestrator: add SNIP-35 integration TODO doc #13982
• apollo_consensus_orchestrator: tmp dirty tests for SNIP-35 (NOT FOR MERGE) #13857 👈 (View in Graphite)
• apollo_l1_gas_price,apollo_l1_gas_price_config: move exchange_rate_decimals const to config #13881
• apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests #13856
• apollo_consensus_orchestrator: add SNIP-35 module edge case tests #13855
• apollo_consensus_orchestrator,apollo_consensus_manager: route STRK/USD via L1GasPriceProvider #14161
• apollo_integration_tests,apollo_deployments: prime strk_to_usd_oracle overlays #14160
• apollo_l1_gas_price_types,apollo_l1_gas_price: expose get_strk_to_usd_rate #14159
• apollo_l1_gas_price: hold strk_to_usd oracle client + strk_to_usd_rate #14158
• apollo_l1_gas_price: parameterize ExchangeRateOracleClient by metric set #14199
• apollo_l1_gas_price_config,apollo_node: add strk_to_usd_oracle_config #14157
• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819 : 1 other dependent PR (#13820 )
• apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash #13949
• apollo_starknet_client: read fee_proposal_fri from feeder gateway #13986
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob #13985
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818
• apollo_consensus_orchestrator,apollo_consensus_manager: move SNIP-35 bootstrap to pre-consensus #14061
• apollo_node_config: made validation only node hold full state #14122
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 9fd2bd9. Configure here.}

[cursor]

Explicitly "NOT FOR MERGE" test files committed

Medium Severity

Both new test files carry explicit "NOT FOR MERGE" declarations in their module-level doc comments (snip35_stress_test.rs line 3: "These tests are NOT intended to be merged", snip35_integration_test.rs line 3: "NOT FOR MERGE"), and the PR title repeats this. Nevertheless, both are wired into the build via #[cfg(test)] mod declarations in fee_market/mod.rs and lib.rs. While the #[cfg(test)] gate prevents production impact, these files — along with their module registrations — would land in the main branch if this PR were merged.

Additional Locations (1)

• crates/apollo_consensus_orchestrator/src/snip35_integration_test.rs#L1-L8

 

^{Reviewed by Cursor Bugbot for commit 9fd2bd9. Configure here.}