Skip to content

apollo_l1_gas_price_types,apollo_l1_gas_price: rename trait method eth_to_fri_rate to fetch_rate#13987

Merged
sirandreww-starkware merged 2 commits into
mainfrom
05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate
May 14, 2026
Merged

apollo_l1_gas_price_types,apollo_l1_gas_price: rename trait method eth_to_fri_rate to fetch_rate#13987
sirandreww-starkware merged 2 commits into
mainfrom
05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented May 6, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware sirandreww-starkware self-assigned this May 6, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review May 6, 2026 13:22
@cursor
Copy link
Copy Markdown

cursor Bot commented May 6, 2026

PR Summary

Low Risk
Low risk rename-only API change; main risk is missed call sites causing compile failures rather than runtime behavior changes.

Overview
Renames ExchangeRateOracleClientTrait::eth_to_fri_rate to fetch_rate and updates the concrete ExchangeRateOracleClient implementation.

Updates L1GasPriceProvider and oracle client tests to use the new method name, and clarifies trait docs that the per-instance rate semantics are determined by configured URLs (not hardcoded to ETH/FRI).

Reviewed by Cursor Bugbot for commit 426c2cd. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware changed the base branch from 05-04-apollo_dashboard_add_snip-35_row to graphite-base/13987 May 6, 2026 13:33
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate branch from feb9526 to 83bbe20 Compare May 6, 2026 13:49
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13987 to 05-04-apollo_dashboard_add_snip-35_row May 6, 2026 13:49
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from 354cf9c to ec16cd6 Compare May 8, 2026 12:36
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate branch 2 times, most recently from 385721d to 392528a Compare May 10, 2026 09:02
@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch 2 times, most recently from 312819a to a9cbd37 Compare May 10, 2026 09:07
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate branch from 392528a to 5e05240 Compare May 10, 2026 09:07
@sirandreww-starkware sirandreww-starkware force-pushed the 05-04-apollo_dashboard_add_snip-35_row branch from a9cbd37 to ea9fb4f Compare May 10, 2026 12:15
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate branch from 5e05240 to d814567 Compare May 10, 2026 12:15
@graphite-app graphite-app Bot changed the base branch from 05-04-apollo_dashboard_add_snip-35_row to graphite-base/13987 May 11, 2026 12:57
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_l1_gas_price_types_apollo_l1_gas_price_rename_trait_method_eth_to_fri_rate_to_fetch_rate branch from d814567 to 426c2cd Compare May 14, 2026 07:00
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13987 to 05-04-apollo_dashboard_add_snip-35_row May 14, 2026 07:00
@sirandreww-starkware sirandreww-starkware changed the base branch from 05-04-apollo_dashboard_add_snip-35_row to main May 14, 2026 07:39
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 7 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit ec71933 May 14, 2026
35 of 57 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants