apollo_consensus_orchestrator,apollo_consensus_manager: add strk_exchange_rate_oracle field to deps

[sirandreww-starkware]

No description provided.

[sirandreww-starkware]

• apollo_consensus_orchestrator: add SNIP-35 integration TODO doc #13982
• apollo_consensus_orchestrator: tmp dirty tests for SNIP-35 (NOT FOR MERGE) #13857
• apollo_l1_gas_price,apollo_l1_gas_price_config: move exchange_rate_decimals const to config #13881
• apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests #13856
• apollo_consensus_orchestrator: add SNIP-35 module edge case tests #13855
• apollo_consensus_orchestrator: add SNIP-35 e2e test #13821
• apollo_consensus_manager: wire STRK/USD oracle into consensus manager #13820
• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819
• apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash #13949
• apollo_starknet_client: read fee_proposal_fri from feeder gateway #13986
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob #13985
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818
• apollo_consensus_orchestrator,apollo_consensus_manager: move SNIP-35 bootstrap to pre-consensus #14061
• apollo_consensus_orchestrator: add fee_actual floor to EIP-1559 gas price calculation #13824
• apollo_consensus_orchestrator: add SNIP-35 fee_proposals sliding window #13817
• apollo_consensus_orchestrator,apollo_consensus_manager: add strk_exchange_rate_oracle field to deps #13823 👈 (View in Graphite)
• apollo_l1_gas_price_types,apollo_l1_gas_price: rename trait method eth_to_fri_rate to fetch_rate #13987
• apollo_dashboard: add SNIP-35 row #13954
• apollo_consensus_orchestrator: add SNIP-35 metrics #13816
• apollo_consensus_orchestrator: add SNIP-35 module tests #13815
• apollo_consensus_orchestrator: add SNIP-35 module #13854
• apollo_storage: add fee_proposal_fri migrator and bump blocks version to 6.1 #13936 : 2 other dependent PRs (#13814 , #13934 )
• apollo_protobuf: add fee_proposal_fri to sync proto SignedBlockHeader #13957
• starknet_api: add fee_proposal_fri to BlockHeaderWithoutHash #13822
• apollo_protobuf: add fee_proposal_fri to ProposalInit #13812 : 2 other dependent PRs (#13811 , #13935 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[ShahakShama]

@ShahakShama reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

---

crates/apollo_consensus_manager/src/consensus_manager.rs line 307 at r1 (raw file):

                vote_broadcast_client: votes_broadcast_channels.broadcast_topic_client.clone(),
                config_manager_client: Some(Arc::clone(&config_manager_client)),
                strk_exchange_rate_oracle: None,

Is this strk to eth or strk to usd? Rename to reflect. If it's the latter, why is the former not here?

[ShahakShama]

@ShahakShama made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on matanl-starkware and sirandreww-starkware).

---

a discussion (no related file):
@matanl-starkware should also review

[sirandreww-starkware]

@sirandreww-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on matanl-starkware and ShahakShama).

---

crates/apollo_consensus_manager/src/consensus_manager.rs line 307 at r1 (raw file):

Previously, ShahakShama wrote…

Is this strk to eth or strk to usd? Rename to reflect. If it's the latter, why is the former not here?

Why do we need the STRK to ETH here? the STRK to ETH is in L1 gas price

[ShahakShama]

@ShahakShama reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on matanl-starkware and sirandreww-starkware).

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 1978c0d. Configure here.}

[sirandreww-starkware]

@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on matanl-starkware).

[matanl-starkware]

@matanl-starkware reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).

[sirandreww-starkware]

@sirandreww-starkware reviewed 3 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).