Skip to content

starknet_api: add fee_proposal_fri to BlockHeaderWithoutHash#13822

Merged
sirandreww-starkware merged 1 commit into
mainfrom
04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents
May 6, 2026
Merged

starknet_api: add fee_proposal_fri to BlockHeaderWithoutHash#13822
sirandreww-starkware merged 1 commit into
mainfrom
04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

@sirandreww-starkware sirandreww-starkware commented Apr 19, 2026

No description provided.

This was referenced Apr 19, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@reviewable-StarkWare
Copy link
Copy Markdown

reviewable-StarkWare commented Apr 19, 2026

This change is Reviewable

This was referenced Apr 19, 2026
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
@sirandreww-starkware Graphite App
Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 19, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Apr 19, 2026
Closed
Closed
Merged
Merged
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_storage_add_fee_proposal_to_storageblockheader branch from c31397c to ed1364d Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents branch from f202779 to 3f7c331 Compare April 23, 2026 11:59
This was referenced Apr 23, 2026
Merged
Open
Open
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents branch from 88855dd to c63c17b Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_protobuf_add_fee_proposal_to_proposalinit_and_l2gasinfo branch from 1d87778 to 43baf6f Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware changed the title starknet_api: add fee_proposal_fri to BlockHeaderWithoutHash starknet_api: add fee_proposal_fri to BlockHeaderWithoutHash and PartialBlockHashComponents May 1, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents branch from c63c17b to 5bd891e Compare May 1, 2026 17:05
sirandreww-starkware
sirandreww-starkware commented May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on matanl-starkware and ShahakShama).

Comment thread crates/apollo_storage/src/serialization/serializers.rs Outdated
sirandreww-starkware
sirandreww-starkware commented May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware resolved 1 discussion.
Reviewable status: 0 of 13 files reviewed, all discussions resolved (waiting on matanl-starkware and ShahakShama).

@sirandreww-starkware sirandreww-starkware changed the title starknet_api: add fee_proposal_fri to BlockHeaderWithoutHash and PartialBlockHashComponents starknet_api: add fee_proposal_fri to BlockHeaderWithoutHash May 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026 •
edited
Loading

Artifacts upload workflows:

@sirandreww-starkware sirandreww-starkware changed the base branch from 04-19-apollo_protobuf_add_fee_proposal_to_proposalinit_and_l2gasinfo to graphite-base/13822 May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents branch from 5bd891e to b562ff0 Compare May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13822 to main May 3, 2026 12:59
@sirandreww-starkware sirandreww-starkware mentioned this pull request May 3, 2026
Merged
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents branch 2 times, most recently from a8476f4 to a942277 Compare May 4, 2026 10:25
@sirandreww-starkware sirandreww-starkware mentioned this pull request May 4, 2026
Merged
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents branch 2 times, most recently from 4f8ff9e to 9142e23 Compare May 5, 2026 06:53
This was referenced May 5, 2026
Merged
Closed
ShahakShama
ShahakShama requested changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 14 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on matanl-starkware and sirandreww-starkware).

crates/starknet_api/src/block.rs line 244 at r6 (raw file):

    pub l1_da_mode: L1DataAvailabilityMode,
    pub starknet_version: StarknetVersion,
    /// SNIP-35: proposer's oracle-derived recommended fee. `None` for pre-V0_14_3 blocks.

Add TODO to add this field into block hash

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents branch from 9142e23 to 2513044 Compare May 6, 2026 08:25
sirandreww-starkware
sirandreww-starkware commented May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: 13 of 14 files reviewed, 1 unresolved discussion (waiting on matanl-starkware and ShahakShama).

crates/starknet_api/src/block.rs line 244 at r6 (raw file):

Previously, ShahakShama wrote…

Add TODO to add this field into block hash

Done.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-starknet_api_add_fee_proposal_to_partialblockhashcomponents branch from 2513044 to df1857a Compare May 6, 2026 08:51
ShahakShama
ShahakShama approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on matanl-starkware).

This was referenced May 6, 2026
Merged
Merged
Merged
@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@ShahakShama ShahakShama ShahakShama approved these changes

@matanl-starkware matanl-starkware Awaiting requested review from matanl-starkware

Assignees

@sirandreww-starkware sirandreww-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sirandreww-starkware @reviewable-StarkWare @ShahakShama