apollo_storage: add fee_proposal_fri migrator and bump blocks version to 6.1#13936
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryMedium Risk Overview Implements a v0→v1 migrator for Switches the Reviewed by Cursor Bugbot for commit a2d833c. Bugbot is set up for automated code reviews on this repo. Configure here. |
1b57f15 to
d961488
Compare
62e988c to
88855dd
Compare
88855dd to
c63c17b
Compare
3bf12c1 to
6a92d7c
Compare
4f8ff9e to
3e86fde
Compare
3e86fde to
e9914f7
Compare
6a92d7c to
c202246
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and sirandreww-starkware).
crates/apollo_storage/src/deprecated/migrations.rs line 32 at r2 (raw file):
CURRENT_VERSION.. => { error!( "Unable to migrate stored header from version {} to current version.",
The message here should make it clear that the problem is in the version number
Maybe something like "Version {} is >= current version. Can't migrate"
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and sirandreww-starkware).
e9914f7 to
3ec6c37
Compare
c202246 to
fafa7d5
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware resolved 1 discussion.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on dorimedini-starkware and ShahakShama).
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).
fafa7d5 to
b0f1afe
Compare
3ec6c37 to
511b6da
Compare
Merge activity
|
b0f1afe to
a2d833c
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

No description provided.