apollo_committer: add request_paths_and_commit_block tests

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_committer: add new request handler #14003
• apollo_committer: add request_paths_and_commit_block tests #14208 👈 (View in Graphite)
• starknet_committer: delete patricia paths on reverts #14002
• starknet_committer,apollo_committer: add timers for fetch patricia paths #14189
• starknet_committer: underlying logic of the new read witnesses and commit endpoint #14001
• starknet_committer: extract metadata construction to a function #14000
• starknet_committer: extract commit plan to commit_or_load #13999
• starknet_committer: read and write patricia paths to index db #13998
• starknet_committer: db keys for proofs and accessed keys digest #13997
• apollo_committer_types: add patricia proofs request and response types #13996
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Test-only changes and a gated IndexDb helper; no production committer or storage behavior changes.

Overview
Adds integration tests for read_paths_and_commit_block behind the os_input feature, wired from committer_test.rs into a new request_paths_and_commit_block_tests module.

The happy-path test commits a rich state diff with accessed vs unaccessed keys, checks returned Patricia proofs by re-fetching paths from witness preimages (classes, contracts, per-contract storage), then strips live trie nodes and replays the same request to assert idempotent global root and proofs from persisted witnesses. A second test covers revert_block clearing the witnesses digest and stored Patricia payload for that height.

Test-only support: dev-deps on starknet_committer (os_input, testing) and starknet_patricia; IndexDb::clear_patricia_trie_nodes_for_test retains metadata and witness keys while dropping Patricia node entries so replay cannot rely on trie storage.

^{Reviewed by Cursor Bugbot for commit 4a2b243. Bugbot is set up for automated code reviews on this repo. Configure here.}

[yoavGrs]

@yoavGrs partially reviewed 3 files and made 5 comments.
Reviewable status: 1 of 5 files reviewed, 5 unresolved discussions (waiting on ArielElp).

---

a discussion (no related file):
Please split it into settings (block structure) and logic (verify functions) PRs.

---

crates/apollo_committer/src/request_paths_and_commit_block_tests.rs line 81 at r1 (raw file):

}

fn accessed_keys() -> AccessedKeys {

Do the naming clearer - what are the block 0 settings, and what are the general constants.

Code quote:

fn accessed_keys()

---

crates/apollo_committer/src/request_paths_and_commit_block_tests.rs line 111 at r1 (raw file):

            accessed_contract_2(),
            HashMap::from([(accessed_storage_key_2(), StarknetStorageValue(200_u128.into()))]),
        ),

Share the values with block_0_state_diff.
For testing theaccessed_storage_leaves, they should be connected to the committer input.

Code quote:

        (
            accessed_contract_1(),
            HashMap::from([(accessed_storage_key_1(), StarknetStorageValue(100_u128.into()))]),
        ),
        (
            accessed_contract_2(),
            HashMap::from([(accessed_storage_key_2(), StarknetStorageValue(200_u128.into()))]),
        ),

---

crates/apollo_committer/src/request_paths_and_commit_block_tests.rs line 131 at r1 (raw file):

            contract_1 => indexmap! {
                accessed_storage_key_1().0 => 100_u128.into(),
                UNACCESSED_STORAGE_KEY.into() => 300_u128.into(),

The story of block 0 is broken - unacessed key in the state diff.

Code quote:

                accessed_storage_key_1().0 => 100_u128.into(),
                UNACCESSED_STORAGE_KEY.into() => 300_u128.into(),

---

crates/apollo_committer/src/request_paths_and_commit_block_tests.rs line 324 at r1 (raw file):

        let mut storage = MapStorage(storage_map.clone());
        let sorted_leaf_indices = SortedLeafIndices::new(leaf_indices);
        let fetched = fetch_patricia_paths::<L, FactsNodeLayout>(

This needs some explanation. Just to make sure I understand, are you verifying that fetch_patricia_paths for indexes returns the same result for the facts layout?

If that's the core of the test, consider converting it to a more focused unit test.

Code quote:

fetch_patricia_paths::<L, FactsNodeLayout>