starknet_committer: add patricia paths forest reader/writer traits

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_committer: add new request handler #14003
• starknet_committer: delete patricia paths on reverts #14002
• starknet_committer,apollo_committer: add timers for fetch patricia paths #14189
• starknet_committer: underlying logic of the new read witnesses and commit endpoint #14001
• starknet_committer: extract metadata construction to a function #14000
• starknet_committer: extract commit plan to commit_or_load #13999
• starknet_committer: read and write patricia paths to index db #13998
• starknet_committer: db keys for proofs and accessed keys digest #13997
• apollo_committer_types: add patricia proofs request and response types #13996
• starknet_committer: add patricia paths forest reader/writer traits #13995 👈 (View in Graphite)
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArielElp]

@ArielElp made 4 comments.
Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on yoavGrs).

---

crates/starknet_committer/src/db/forest_trait.rs line 53 at r1 (raw file):

Previously, yoavGrs wrote…

Please split between the action and the data.
Actually, how is it implemented for other metadata fields?

So far reverts neatly fit within the same write method, since revert is implemented as the "reverse" commitment. This is not so with witnesses, where I simply want to delete the digest and witnesses. This enum is introduced so that I can still use a single write_with_metadata_and_witnesses for both reverts and the regular flow. As long as I want a single write function (and I think that I do), I need to bundle the action.

I'm deleting the Skip variant, it's a remanent from a time when I thought this will become an argument in the existing flow.

---

crates/starknet_committer/src/db/forest_trait.rs line 62 at r1 (raw file):

Previously, yoavGrs wrote…

IMO

Renamed

---

crates/starknet_committer/src/db/forest_trait.rs line 122 at r1 (raw file):

Previously, yoavGrs wrote…

We already have fn read_metadata.

I did not include witnesses in the metadata, only the digest

---

crates/starknet_committer/src/db/forest_trait.rs line 129 at r1 (raw file):

Previously, yoavGrs wrote…

I don't know what the implementation will be, but if you don't read from storage here, consider moving it out of a reader trait.

This will read from storage (will use fetch_patricia_paths)

[yoavGrs]

@yoavGrs reviewed 2 files and all commit messages, made 2 comments, and resolved 3 discussions.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).

---

crates/starknet_committer/src/db/forest_trait.rs line 117 at r2 (raw file):

#[cfg(feature = "os_input")]
#[async_trait]
pub trait ForestReaderWithWitnesses:

Consider

Suggestion:

trait WitnessesReader: