Skip to content

starknet_committer: move fetch_patricia_paths tests#13960

Merged
ArielElp merged 1 commit into
mainfrom
ariel/move_tests_module
May 26, 2026
Merged

starknet_committer: move fetch_patricia_paths tests#13960
ArielElp merged 1 commit into
mainfrom
ariel/move_tests_module

Conversation

@ArielElp
Copy link
Copy Markdown
Contributor

@ArielElp ArielElp commented May 5, 2026

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

ArielElp commented May 5, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 7, 2026

PR Summary

Low Risk
Test-only module path and include_str fixes; trie traversal production code is unchanged.

Overview
Reorganizes Patricia path-fetch tests so they live in fetch_patricia_paths_tests.rs under src/db/ instead of facts_db/traversal_test.rs, and wires them into trie_traversal via an updated #[path = ...] test module.

Updates include_str! paths for the Python-generated JSON fixtures from ../../../resources/ to ../../resources/, matching the test file’s location so the embedded cases still resolve correctly.

Reviewed by Cursor Bugbot for commit 29b6bbe. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs partially reviewed 2 files and made 2 comments.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on ArielElp).


crates/starknet_committer/src/db.rs line 13 at r1 (raw file):

#[cfg(test)]
mod fetch_patricia_paths_tests;

Define it in trie_traversal.rs.

Code quote:

#[cfg(test)]
mod fetch_patricia_paths_tests;

crates/starknet_committer/src/db/trie_traversal.rs line 57 at r1 (raw file):

#[cfg(test)]
#[path = "facts_db/traversal_test.rs"]

According to code quality, it should stay here.

Suggestion:

#[path = "traversal_test.rs"]

@ArielElp ArielElp force-pushed the ariel/move_tests_module branch from 621d40d to 6d471bd Compare May 14, 2026 08:43
@ArielElp ArielElp force-pushed the ariel/fetch_patricia_paths_tests branch from 22604c1 to 4c3049b Compare May 14, 2026 08:43
@ArielElp ArielElp force-pushed the ariel/move_tests_module branch from 6d471bd to 3f8b451 Compare May 14, 2026 09:03
Copy link
Copy Markdown
Contributor Author

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielElp partially reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on yoavGrs).


crates/starknet_committer/src/db.rs line 13 at r1 (raw file):

Previously, yoavGrs wrote…

Define it in trie_traversal.rs.

Done.


crates/starknet_committer/src/db/trie_traversal.rs line 57 at r1 (raw file):

Previously, yoavGrs wrote…

According to code quality, it should stay here.

You mean under facts_db, it's weird now that it's generic right?
In any case, I moved the definition to trie_traversal.

Copy link
Copy Markdown
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@ArielElp ArielElp force-pushed the ariel/fetch_patricia_paths_tests branch from 4c3049b to 3792ab7 Compare May 17, 2026 09:52
@ArielElp ArielElp force-pushed the ariel/move_tests_module branch from 3f8b451 to 6118d23 Compare May 17, 2026 09:52
@ArielElp ArielElp force-pushed the ariel/move_tests_module branch from 6118d23 to d65c881 Compare May 18, 2026 11:36
@ArielElp ArielElp force-pushed the ariel/fetch_patricia_paths_tests branch from 3792ab7 to 96f6db2 Compare May 18, 2026 11:36
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@dorimedini-starkware partially reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@ArielElp ArielElp force-pushed the ariel/fetch_patricia_paths_tests branch from 96f6db2 to d85d349 Compare May 19, 2026 12:37
@ArielElp ArielElp force-pushed the ariel/move_tests_module branch from d65c881 to 806e180 Compare May 19, 2026 12:37
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@ArielElp ArielElp force-pushed the ariel/fetch_patricia_paths_tests branch from d85d349 to dfe911c Compare May 20, 2026 09:03
@ArielElp ArielElp force-pushed the ariel/move_tests_module branch 2 times, most recently from b9ca6b2 to c7f61b7 Compare May 20, 2026 09:25
@ArielElp ArielElp force-pushed the ariel/fetch_patricia_paths_tests branch from dfe911c to 756c396 Compare May 20, 2026 09:25
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware partially reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware partially reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@ArielElp ArielElp force-pushed the ariel/fetch_patricia_paths_tests branch from 4849ee6 to e15f135 Compare May 25, 2026 13:45
@ArielElp ArielElp force-pushed the ariel/move_tests_module branch from adc19fa to 1e02db5 Compare May 25, 2026 13:45
@ArielElp ArielElp changed the base branch from ariel/fetch_patricia_paths_tests to main May 26, 2026 08:34
@ArielElp ArielElp force-pushed the ariel/move_tests_module branch from 1e02db5 to 98858b4 Compare May 26, 2026 08:36
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 26, 2026

Merge activity

  • May 26, 8:37 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@ArielElp ArielElp force-pushed the ariel/move_tests_module branch from 98858b4 to 29b6bbe Compare May 26, 2026 10:08
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware partially reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@ArielElp ArielElp added this pull request to the merge queue May 26, 2026
Merged via the queue into main with commit f6ab68b May 26, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants