starknet_committer: move fetch_patricia_paths tests#13960
Conversation
621ebfb to
621d40d
Compare
414244d to
22604c1
Compare
PR SummaryLow Risk Overview Updates Reviewed by Cursor Bugbot for commit 29b6bbe. Bugbot is set up for automated code reviews on this repo. Configure here. |
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs partially reviewed 2 files and made 2 comments.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on ArielElp).
crates/starknet_committer/src/db.rs line 13 at r1 (raw file):
#[cfg(test)] mod fetch_patricia_paths_tests;
Define it in trie_traversal.rs.
Code quote:
#[cfg(test)]
mod fetch_patricia_paths_tests;crates/starknet_committer/src/db/trie_traversal.rs line 57 at r1 (raw file):
#[cfg(test)] #[path = "facts_db/traversal_test.rs"]
According to code quality, it should stay here.
Suggestion:
#[path = "traversal_test.rs"]621d40d to
6d471bd
Compare
22604c1 to
4c3049b
Compare
6d471bd to
3f8b451
Compare
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp partially reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on yoavGrs).
crates/starknet_committer/src/db.rs line 13 at r1 (raw file):
Previously, yoavGrs wrote…
Define it in
trie_traversal.rs.
Done.
crates/starknet_committer/src/db/trie_traversal.rs line 57 at r1 (raw file):
Previously, yoavGrs wrote…
According to code quality, it should stay here.
You mean under facts_db, it's weird now that it's generic right?
In any case, I moved the definition to trie_traversal.
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
4c3049b to
3792ab7
Compare
3f8b451 to
6118d23
Compare
6118d23 to
d65c881
Compare
3792ab7 to
96f6db2
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware partially reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
96f6db2 to
d85d349
Compare
d65c881 to
806e180
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
d85d349 to
dfe911c
Compare
b9ca6b2 to
c7f61b7
Compare
dfe911c to
756c396
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware partially reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
c7f61b7 to
adc19fa
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware partially reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
4849ee6 to
e15f135
Compare
adc19fa to
1e02db5
Compare
1e02db5 to
98858b4
Compare
Merge activity
|
98858b4 to
29b6bbe
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware partially reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).

No description provided.