starknet_committer: extract metadata construction to a function#14000
Open
ArielElp wants to merge 1 commit into
Open
starknet_committer: extract metadata construction to a function#14000ArielElp wants to merge 1 commit into
ArielElp wants to merge 1 commit into
Conversation
This was referenced May 7, 2026
|
This change is |
Contributor
Author
This was referenced May 7, 2026
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
97f4dda to
c42c4a2
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
26338f3 to
5337544
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
c42c4a2 to
2892fbe
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
2 times, most recently
from
110f567 to
c65f356
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
2892fbe to
573c4db
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
c65f356 to
79c4633
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
2 times, most recently
from
0ef9967 to
2f5189a
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
79c4633 to
22b07fe
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
2f5189a to
d248e3b
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
22b07fe to
85fb96f
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
2 times, most recently
from
95d0553 to
b82c826
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
61b9419 to
316f527
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
b82c826 to
41f2772
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
2 times, most recently
from
2c5ad8b to
c723eb6
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
41f2772 to
b92314e
Compare
yoavGrs
approved these changes
May 24, 2026
Contributor
yoavGrs
left a comment
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).
a discussion (no related file):
PR 14000 🥇
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
c723eb6 to
4d6033f
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
2 times, most recently
from
781573e to
e216816
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
4d6033f to
16432f8
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
16432f8 to
e66d58a
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
e216816 to
5c08172
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
e66d58a to
c49d13f
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
5c08172 to
b685c0d
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
c49d13f to
afd1741
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
2 times, most recently
from
036d0c6 to
530912e
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
2 times, most recently
from
4de771d to
8111fe7
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
530912e to
334fb68
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
8111fe7 to
d8145ef
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
2 times, most recently
from
b9d7c24 to
a11c9cd
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
d8145ef to
051f86a
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
a11c9cd to
e18eb18
Compare
ArielElp
force-pushed
the
ariel/commit_metadata
branch
from
e18eb18 to
625c60d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.