starknet_committer: extract commit plan to commit_or_load#13999
Open
ArielElp wants to merge 1 commit into
Open
starknet_committer: extract commit plan to commit_or_load#13999ArielElp wants to merge 1 commit into
ArielElp wants to merge 1 commit into
Conversation
This was referenced May 7, 2026
|
This change is |
Contributor
Author
This was referenced May 7, 2026
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
de52d79 to
c3b74da
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
26338f3 to
5337544
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
c3b74da to
7eb2f0e
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
2 times, most recently
from
110f567 to
c65f356
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
2 times, most recently
from
82e9411 to
ff1915d
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
c65f356 to
79c4633
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
ff1915d to
1a13989
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
2 times, most recently
from
22b07fe to
85fb96f
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
1a13989 to
1fd4ef8
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
b8572e0 to
f4c4883
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
61b9419 to
316f527
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
f4c4883 to
409fefe
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
2 times, most recently
from
2c5ad8b to
c723eb6
Compare
ArielElp
commented
May 20, 2026
Contributor
Author
ArielElp
left a comment
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 2 comments and resolved 1 discussion.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on yoavGrs).
crates/apollo_committer/src/committer.rs line 94 at r1 (raw file):
Previously, yoavGrs wrote…
Document please.
Done.
crates/apollo_committer/src/committer.rs line 156 at r1 (raw file):
Previously, yoavGrs wrote…
You are deleting all the comments :(
My bad (or Cursor's), should be there now
ArielElp
commented
May 20, 2026
Contributor
Author
ArielElp
left a comment
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 1 comment.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on yoavGrs).
crates/apollo_committer/src/committer.rs line 132 at r1 (raw file):
Previously, yoavGrs wrote…
Top-down Ordering - start with the public API.
Done.
yoavGrs
approved these changes
May 24, 2026
Contributor
yoavGrs
left a comment
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 2 files and all commit messages, and resolved 3 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
c723eb6 to
4d6033f
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
2 times, most recently
from
22f1def to
d3900ba
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
4d6033f to
16432f8
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
2 times, most recently
from
e66d58a to
c49d13f
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
2 times, most recently
from
9e0493a to
c4ff166
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
c49d13f to
afd1741
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
c4ff166 to
adeee5c
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
2 times, most recently
from
4de771d to
8111fe7
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
adeee5c to
3ab669f
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
8111fe7 to
d8145ef
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
6bcc7c0 to
57671ad
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
d8145ef to
051f86a
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
57671ad to
b5ab234
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
051f86a to
07c4218
Compare
ArielElp
force-pushed
the
ariel/index_db_read_and_write_proofs
branch
from
b5ab234 to
a2756a6
Compare
ArielElp
force-pushed
the
ariel/commit_or_load
branch
from
07c4218 to
2110c62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.