apollo_committer_types: add patricia proofs request and response types

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_committer: add new request handler #14003
• starknet_committer: delete patricia paths on reverts #14002
• starknet_committer,apollo_committer: add timers for fetch patricia paths #14189
• starknet_committer: underlying logic of the new read witnesses and commit endpoint #14001
• starknet_committer: extract metadata construction to a function #14000
• starknet_committer: extract commit plan to commit_or_load #13999
• starknet_committer: read and write patricia paths to index db #13998
• starknet_committer: db keys for proofs and accessed keys digest #13997
• apollo_committer_types: add patricia proofs request and response types #13996 👈 (View in Graphite)
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Type and serialization additions behind an optional feature; no committer behavior changes in this diff.

Overview
Adds OS-input plumbing so the committer can commit a block and return merged Patricia witness proofs in one typed exchange.

Behind the optional os_input feature on apollo_committer_types, new ReadPathsAndCommitBlockRequest / ReadPathsAndCommitBlockResponse pair a normal CommitBlockRequest with AccessedKeys (trie leaves touched during execution) and return global_root plus StarknetForestProofs. CommitterError gains variants for Patricia path collection failures, accessed-keys digest mismatches, and missing stored witness paths.

In starknet_committer, AccessedKeys is defined under os_input, StarknetForestProofs / ContractsTrieProof are Clone, and StarknetForestProofs gets serde via the existing bincode DbValue encoding so proofs can ride on generic serialize/deserialize boundaries.

^{Reviewed by Cursor Bugbot for commit 00a8555. Bugbot is set up for automated code reviews on this repo. Configure here.}

[yoavGrs]

@yoavGrs reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).

---

crates/apollo_committer_types/src/committer_types.rs line 53 at r3 (raw file):

    pub class_hashes: Vec<ClassHash>,
    pub contract_addresses: Vec<ContractAddress>,
    pub contract_storage_keys: HashMap<ContractAddress, Vec<StarknetStorageKey>>,

Please define a struct for this triple.

Code quote:

    pub class_hashes: Vec<ClassHash>,
    pub contract_addresses: Vec<ContractAddress>,
    pub contract_storage_keys: HashMap<ContractAddress, Vec<StarknetStorageKey>>,

[ArielElp]

@ArielElp partially reviewed 3 files and made 2 comments.
Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on yoavGrs).

---

crates/apollo_committer_types/src/committer_types.rs line 53 at r3 (raw file):

Previously, yoavGrs wrote…

Please define a struct for this triple.

Done, though I prefer plugging it earlier if possible on top of the stack rather than here/below

[yoavGrs]

@yoavGrs reviewed 3 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

---

crates/apollo_committer_types/src/committer_types.rs line 53 at r3 (raw file):

Previously, ArielElp wrote…

Done, though I prefer plugging it earlier if possible on top of the stack rather than here/below

Ohh, you already did it.
I don't care where you insert this type.

---

crates/starknet_committer/src/block_committer/input.rs line 79 at r4 (raw file):

/// Trie leaves read during block execution (classes, contracts, and per-contract storage slots).
#[derive(Clone, Debug, Default, Deserialize, Eq, PartialEq, Serialize)]
pub struct AccessedKeys {

Right?

Suggestion:

#[cfg(feature = "os_input")]
pub struct AccessedKeys {

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on yoavGrs).

---

crates/starknet_committer/src/block_committer/input.rs line 79 at r4 (raw file):

Previously, yoavGrs wrote…

Right?

Done.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c3937ca. Configure here.}

[yoavGrs]

@yoavGrs reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).