starknet_committer: abstract fetch_all_patricia_paths

[ArielElp]

No description provided.

[ArielElp]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_committer: add new request handler #14003
• starknet_committer: delete patricia paths on reverts #14002
• starknet_committer,apollo_committer: add timers for fetch patricia paths #14189
• starknet_committer: underlying logic of the new read witnesses and commit endpoint #14001
• starknet_committer: extract metadata construction to a function #14000
• starknet_committer: extract commit plan to commit_or_load #13999
• starknet_committer: read and write patricia paths to index db #13998
• starknet_committer: db keys for proofs and accessed keys digest #13997
• apollo_committer_types: add patricia proofs request and response types #13996
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991 👈 (View in Graphite)
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[cursor]

PR Summary

Medium Risk
Changes trie witness fetching and leaf conversion on a committer-critical path; behavior should match facts layout when FactsNodeLayout is used, but the abstraction touches all three tries.

Overview
fetch_all_patricia_paths is now public and parameterized by a DbLayout type instead of hardcoding facts-db leaf types and FactsNodeLayout. Patricia path fetches for classes, contracts, and per-contract storage use Layout::…DbLeaf and Layout::NodeLayout, with contract trie leaves converted via AsRef / Into when reading storage roots and building ContractState maps.

fetch_previous_and_new_patricia_paths still calls the helper with FactsNodeLayout only; its doc comment notes it only works with facts-layout storage.

^{Reviewed by Cursor Bugbot for commit 823105d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[yoavGrs]

@yoavGrs reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

---

crates/starknet_committer/src/patricia_merkle_tree/tree.rs line 129 at r1 (raw file):

        // prove regarding the contract storage.
        let Some(storage_root_hash) =
            leaves.get(idx).map(|leaf| leaf.clone().into().storage_root_hash)

Can you avoid cloning?

Code quote:

leaf.clone().into().storage_root_hash

[ArielElp]

@ArielElp partially reviewed 1 file and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on yoavGrs).

---

crates/starknet_committer/src/patricia_merkle_tree/tree.rs line 129 at r1 (raw file):

Previously, yoavGrs wrote…

Can you avoid cloning?

Replaced the Clone bound with AsRef to circumvent cloning

[yoavGrs]

@yoavGrs reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).