Skip to content

starknet_committer: db keys for proofs and accessed keys digest#13997

Open
ArielElp wants to merge 1 commit into
ariel/add_committer_request_typesfrom
ariel/patricia_proofs_db_keys
Open

starknet_committer: db keys for proofs and accessed keys digest#13997
ArielElp wants to merge 1 commit into
ariel/add_committer_request_typesfrom
ariel/patricia_proofs_db_keys

Conversation

@ArielElp
Copy link
Copy Markdown
Contributor

@ArielElp ArielElp commented May 7, 2026

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

ArielElp commented May 7, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from dfd62d8 to c672275 Compare May 7, 2026 12:40
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch from 1653f27 to b645f94 Compare May 14, 2026 08:43
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from c672275 to 765284d Compare May 14, 2026 08:43
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch from b645f94 to abf2f2d Compare May 18, 2026 11:56
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch 2 times, most recently from 2562066 to d34fe2c Compare May 18, 2026 13:52
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch 2 times, most recently from bc12ddd to 9e42fdf Compare May 19, 2026 06:55
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from d34fe2c to 509ef2f Compare May 19, 2026 06:55
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch from 9e42fdf to 9ab840a Compare May 19, 2026 07:08
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 509ef2f to 4f7483a Compare May 19, 2026 07:08
@ArielElp ArielElp marked this pull request as ready for review May 19, 2026 07:08
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch from 149ed09 to fe9cd70 Compare May 20, 2026 09:25
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 50f13fd to 0209962 Compare May 20, 2026 09:25
Copy link
Copy Markdown
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).


crates/starknet_committer/src/db/index_db/db.rs line 96 at r1 (raw file):

    LazyLock::new(|| (Felt::from_bytes_be(&STATE_ROOT_METADATA_PREFIX) + Felt::ONE).to_bytes_be());

/// Prefix for merged Patricia proofs payload KV (per block).

What is it? key-value?

Code quote:

KV

crates/starknet_committer/src/db/index_db/db.rs line 102 at r1 (raw file):

});

/// DB key for persisted merged Patricia proofs at `height`.

Doc the structure of the key.

@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch from fe9cd70 to 6f5d728 Compare May 20, 2026 11:20
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 0209962 to 5602190 Compare May 20, 2026 11:20
Copy link
Copy Markdown
Contributor Author

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielElp made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on yoavGrs).


crates/starknet_committer/src/db/index_db/db.rs line 96 at r1 (raw file):

Previously, yoavGrs wrote…

What is it? key-value?

Yeah but it's weird here, removed (the value itself is a hash --> preimage map but "payload" is fine)


crates/starknet_committer/src/db/index_db/db.rs line 102 at r1 (raw file):

Previously, yoavGrs wrote…

Doc the structure of the key.

Done.

@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 5602190 to 371b039 Compare May 20, 2026 11:28
Copy link
Copy Markdown
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 371b039 to f366550 Compare May 25, 2026 08:57
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch 2 times, most recently from 4c2b0c8 to c3937ca Compare May 25, 2026 08:58
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from f366550 to b7b568e Compare May 25, 2026 08:58
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch 2 times, most recently from d7f7286 to 2bc53b6 Compare May 25, 2026 13:45
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch 2 times, most recently from 0cc7e15 to eb8b441 Compare May 25, 2026 13:58
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch 2 times, most recently from 9e35c51 to 0edc7de Compare May 25, 2026 14:13
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch from eb8b441 to 0a642cf Compare May 25, 2026 14:13
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 0edc7de to fd1cced Compare May 26, 2026 10:08
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch from 5f05076 to 8d87f0b Compare May 26, 2026 10:48
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch 2 times, most recently from 6506c10 to 5a5e21c Compare May 26, 2026 11:42
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch 2 times, most recently from 16a3024 to d0b8e0c Compare May 26, 2026 13:03
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 5a5e21c to 12faee1 Compare May 26, 2026 13:03
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 12faee1 to 267f776 Compare May 26, 2026 13:11
@ArielElp ArielElp force-pushed the ariel/add_committer_request_types branch from d0b8e0c to 00a8555 Compare May 26, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants