starknet_committer: db keys for proofs and accessed keys digest#13997
starknet_committer: db keys for proofs and accessed keys digest#13997ArielElp wants to merge 1 commit into
Conversation
dfd62d8 to
c672275
Compare
1653f27 to
b645f94
Compare
c672275 to
765284d
Compare
b645f94 to
abf2f2d
Compare
2562066 to
d34fe2c
Compare
bc12ddd to
9e42fdf
Compare
d34fe2c to
509ef2f
Compare
9e42fdf to
9ab840a
Compare
509ef2f to
4f7483a
Compare
149ed09 to
fe9cd70
Compare
50f13fd to
0209962
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).
crates/starknet_committer/src/db/index_db/db.rs line 96 at r1 (raw file):
LazyLock::new(|| (Felt::from_bytes_be(&STATE_ROOT_METADATA_PREFIX) + Felt::ONE).to_bytes_be()); /// Prefix for merged Patricia proofs payload KV (per block).
What is it? key-value?
Code quote:
KVcrates/starknet_committer/src/db/index_db/db.rs line 102 at r1 (raw file):
}); /// DB key for persisted merged Patricia proofs at `height`.
Doc the structure of the key.
fe9cd70 to
6f5d728
Compare
0209962 to
5602190
Compare
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on yoavGrs).
crates/starknet_committer/src/db/index_db/db.rs line 96 at r1 (raw file):
Previously, yoavGrs wrote…
What is it? key-value?
Yeah but it's weird here, removed (the value itself is a hash --> preimage map but "payload" is fine)
crates/starknet_committer/src/db/index_db/db.rs line 102 at r1 (raw file):
Previously, yoavGrs wrote…
Doc the structure of the key.
Done.
5602190 to
371b039
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
371b039 to
f366550
Compare
4c2b0c8 to
c3937ca
Compare
f366550 to
b7b568e
Compare
d7f7286 to
2bc53b6
Compare
0cc7e15 to
eb8b441
Compare
9e35c51 to
0edc7de
Compare
eb8b441 to
0a642cf
Compare
0edc7de to
fd1cced
Compare
5f05076 to
8d87f0b
Compare
6506c10 to
5a5e21c
Compare
16a3024 to
d0b8e0c
Compare
5a5e21c to
12faee1
Compare
12faee1 to
267f776
Compare
d0b8e0c to
00a8555
Compare

No description provided.