Skip to content

deployment: define common env#14196

Open
nimrod-starkware wants to merge 1 commit into
05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlaysfrom
05-26-deployment_define_common_env
Open

deployment: define common env#14196
nimrod-starkware wants to merge 1 commit into
05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlaysfrom
05-26-deployment_define_common_env

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 26, 2026

PR Summary

Medium Risk
Touches production hybrid deployment merge paths; incorrect include resolution or drift from removed inline keys could change probes, env, ports, or sequencer settings at deploy time.

Overview
Hybrid sequencer overlays for mainnet, sepolia-alpha, and sepolia-integration now pull shared settings via include: from configs/overlays/hybrid/common/ instead of duplicating them in each environment.

Per-env YAML keeps only deltas (e.g. image tag, chain_id, feeder/recorder URLs, L1 contract addresses, batcher/consensus/state-sync overrides). Removed from env files: repeated image metadata, fee-token and versioned-constant keys, health probes, GCP monitoring, env (RUST_LOG, RUST_BACKTRACE, NO_COLOR), Kubernetes service ports, configList paths, inter-service components URLs/ports, and most shared sequencerConfig blocks—those live in the common layer. Gateway/mempool overlays can be include-only.

merger._load_common_yaml now loads common.yaml through DeploymentConfigLoader._load_one_file_with_includes (with config_base_dir) so overlay common files resolve include: the same way service configs already do.

Reviewed by Cursor Bugbot for commit 5077593. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants