Skip to content

deployment: add starknet_url to hybrid environment overlays#14179

Merged
nimrod-starkware merged 1 commit into
mainfrom
05-25-deployment_add_starknet_url_to_hybrid_environment_overlays
May 26, 2026
Merged

deployment: add starknet_url to hybrid environment overlays#14179
nimrod-starkware merged 1 commit into
mainfrom
05-25-deployment_add_starknet_url_to_hybrid_environment_overlays

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented May 25, 2026

Add starknet_url to config.sequencerConfig in each production hybrid environment overlay:

  • mainnet/common.yaml: https://feeder.alpha-mainnet.starknet.io/
  • sepolia-alpha/common.yaml: https://feeder.alpha-sepolia.starknet.io/
  • sepolia-integration/common.yaml: https://feeder.integration-sepolia.starknet.io/

Corresponding devops PR (removes the same key from the devops overlays): starkware-industries/sequencer-devops#701

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_starknet_url_to_hybrid_environment_overlays branch from 3b60e9c to bfe2921 Compare May 25, 2026 07:44
@nimrod-starkware nimrod-starkware self-assigned this May 25, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review May 25, 2026 07:53
@cursor
Copy link
Copy Markdown

cursor Bot commented May 25, 2026

PR Summary

Medium Risk
Wrong feeder URL on production hybrid networks could misconfigure how the sequencer talks to Starknet; scope is limited to three YAML overlays.

Overview
Adds starknet_url under config.sequencerConfig in the three production hybrid overlay common.yaml files, each pointing at the matching Starknet feeder endpoint (alpha mainnet, alpha Sepolia, integration Sepolia).

This aligns hybrid deployment config with how other overlays already set feeder URLs; the paired devops change removes the same key from devops overlays so the value lives in one place per environment.

Reviewed by Cursor Bugbot for commit bfe2921. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on matanl-starkware).

@nimrod-starkware nimrod-starkware added this pull request to the merge queue May 26, 2026
Merged via the queue into main with commit a6e2d79 May 26, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants