deployment: add gcp pod monitoring to hybrid environment overlays

[nimrod-starkware]

Cross-repo PR: https://github.com/starkware-industries/sequencer-devops/pull/719

Cross-repo PR: https://github.com/starkware-industries/sequencer-devops/pull/719

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• deployment: define common env #14196
• deployment: add gcp pod monitoring to hybrid environment overlays #14192 👈 (View in Graphite)
• deployment: add liveness probe to hybrid environment overlays #14191
• deployment: add readiness probe to hybrid environment overlays #14190
• deployment: add startup probe to hybrid environment overlays #14188
• deployment: add monitoring endpoint port to hybrid environment overlays #14187
• deployment: add service ports to hybrid environment overlays #14185
• deployment: move network and consensus ports to hybrid environment overlays #14183
• deployment: add component ports and urls to hybrid environment overlays #14181
• deployment: add recorder_url to hybrid environment overlays #14180
• deployment: add starknet_url to hybrid environment overlays #14179
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Observability-only Helm overlay changes; no application logic, auth, or runtime behavior changes beyond metrics collection config.

Overview
Enables GCP PodMonitoring for hybrid sequencer deployments on mainnet, sepolia-alpha, and sepolia-integration by setting gcpPodMonitoring.enabled: true in each environment’s common.yaml overlay.

Each overlay adds the same scrape spec: port 8082, path /monitoring/metrics, interval 10s, aligned with the existing monitoring-endpoint service port already defined in those files.

^{Reviewed by Cursor Bugbot for commit 77b2c59. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 77b2c59. Configure here.}

[cursor]

Common overlay enabled: true silently overridden by service defaults

High Severity

Setting gcpPodMonitoring.enabled: true in the common overlay has no effect. Every service layout file (e.g. core.yaml, gateway.yaml, etc.) already defines gcpPodMonitoring.enabled: false. During _merge_common_into_service, the deep_merge function uses the service dict as base and common dict as overlay, and only adds keys from the overlay that don't already exist in the base. Since enabled: false already exists in each service, the common's enabled: true is silently discarded. Pod monitoring will remain disabled for all services.

Additional Locations (2)

• deployments/sequencer/configs/overlays/hybrid/sepolia-alpha/common.yaml#L46-L53
• deployments/sequencer/configs/overlays/hybrid/sepolia-integration/common.yaml#L46-L53

 

^{Reviewed by Cursor Bugbot for commit 77b2c59. Configure here.}