Skip to content

deployment: move network and consensus ports to hybrid environment overlays#14183

Open
nimrod-starkware wants to merge 1 commit into
05-25-deployment_add_component_ports_and_urls_to_hybrid_environment_overlaysfrom
05-25-deployment_add_storage_reader_state_sync_network_and_consensus_ports_to_hybrid_environment_overlays
Open

deployment: move network and consensus ports to hybrid environment overlays#14183
nimrod-starkware wants to merge 1 commit into
05-25-deployment_add_component_ports_and_urls_to_hybrid_environment_overlaysfrom
05-25-deployment_add_storage_reader_state_sync_network_and_consensus_ports_to_hybrid_environment_overlays

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented May 25, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_storage_reader_state_sync_network_and_consensus_ports_to_hybrid_environment_overlays branch from ad8129b to 7b0b0a0 Compare May 25, 2026 08:44
@nimrod-starkware nimrod-starkware changed the title deployment: add storage_reader, state_sync network and consensus ports to hybrid environment overlays deployment: move network and consensus ports to hybrid environment overlays May 25, 2026
@nimrod-starkware nimrod-starkware self-assigned this May 25, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review May 25, 2026 08:47
@cursor
Copy link
Copy Markdown

cursor Bot commented May 25, 2026

PR Summary

Low Risk
Deployment-only port and network toggles in YAML overlays; misconfiguration could affect connectivity but does not change application logic.

Overview
Adds hybrid core service overlay keys for consensus, batcher/class storage readers, and state sync networking across mainnet, sepolia-alpha, and sepolia-integration.

Each environment now sets consensus_manager_config.network_config.port to 53080, storage reader ports (55011 / 55210), and state sync ports (55010, 8090, 55012). Mainnet enables state sync P2P via state_sync_config.static_config.network_config.#is_none: false; the two Sepolia overlays keep P2P disabled (#is_none: true) while still defining the port values.

Reviewed by Cursor Bugbot for commit 7b0b0a0. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7b0b0a0. Configure here.

state_sync_config.static_config.network_config.port: 55010
state_sync_config.static_config.p2p_sync_client_config.#is_none: true
state_sync_config.static_config.rpc_config.port: 8090
state_sync_config.static_config.storage_reader_server_static_config.port: 55012
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port 55012 conflict between proof_manager and state_sync storage reader

High Severity

The newly added state_sync_config.static_config.storage_reader_server_static_config.port: 55012 conflicts with the pre-existing components.proof_manager.port: 55012. Both create TCP listeners on port 55012 within the same core service pod — the proof_manager creates a gRPC remote server bound to 0.0.0.0:55012, and the storage reader server creates an HTTP server also on 0.0.0.0:55012. This will cause an "address already in use" error at startup in all three environments.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7b0b0a0. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants