Skip to content

starknet_transaction_prover: origin-level breadcrumbs for validation errors#14172

Open
avi-starkware wants to merge 1 commit into
avi/prover-v3/saturation-healthfrom
avi/prover-v3/error-origin-logs
Open

starknet_transaction_prover: origin-level breadcrumbs for validation errors#14172
avi-starkware wants to merge 1 commit into
avi/prover-v3/saturation-healthfrom
avi/prover-v3/error-origin-logs

Conversation

@avi-starkware
Copy link
Copy Markdown
Collaborator

Splits validation-error logging so each origin (request body, RPC,
proving) carries an event tag and trimmed payload context, making it
straightforward to root-cause production failures from the structured
log stream. Also adds an in-test microbenchmark for HttpMetricsLayer
overhead so any regression in the hot path is visible.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Observability-only logging and test-only benchmarks; no change to proving logic, auth, or transaction handling.

Overview
Adds structured validation and failure logging in the proving path so production issues can be filtered by stable event / reason fields without logging transaction calldata.

In virtual_snos_prover, each validation failure now emits a warn with event = "validation_error" and a specific reason (pending block, non-invoke tx, invalid input) via inspect_err on extract/validate. The RPC layer’s prove handler logs failures with event = "prove_transaction_failed" and outcome aligned with prover_prove_transaction_outcome_total metrics.

Also introduces ignored release microbenchmarks (server/overhead_bench) to compare baseline Tower throughput vs HttpMetricsLayer steady-state overhead for observability rollout checks.

Reviewed by Cursor Bugbot for commit b7d03bd. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@avi-starkware avi-starkware force-pushed the avi/prover-v3/error-origin-logs branch from e57d84d to eba2906 Compare May 24, 2026 16:48
@avi-starkware avi-starkware force-pushed the avi/prover-v3/saturation-health branch from 53381dd to d477f5e Compare May 26, 2026 08:43
@avi-starkware avi-starkware force-pushed the avi/prover-v3/error-origin-logs branch from eba2906 to 22db0d1 Compare May 26, 2026 08:43
@avi-starkware avi-starkware force-pushed the avi/prover-v3/saturation-health branch from d477f5e to ef3cf0b Compare May 26, 2026 12:16
@avi-starkware avi-starkware force-pushed the avi/prover-v3/error-origin-logs branch from 22db0d1 to 9773ef7 Compare May 26, 2026 12:16
…errors

Splits validation-error logging so each origin (request body, RPC,
proving) carries an `event` tag and trimmed payload context, making it
straightforward to root-cause production failures from the structured
log stream. Also adds an in-test microbenchmark for HttpMetricsLayer
overhead so any regression in the hot path is visible.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@avi-starkware avi-starkware force-pushed the avi/prover-v3/saturation-health branch from ef3cf0b to eb8da8d Compare May 26, 2026 12:17
@avi-starkware avi-starkware force-pushed the avi/prover-v3/error-origin-logs branch from 9773ef7 to b7d03bd Compare May 26, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants