Skip to content

starknet_transaction_prover: add /health endpoint via HealthLayer#14163

Merged
avi-starkware merged 1 commit into
mainfrom
avi/prover-v3/health
May 26, 2026
Merged

starknet_transaction_prover: add /health endpoint via HealthLayer#14163
avi-starkware merged 1 commit into
mainfrom
avi/prover-v3/health

Conversation

@avi-starkware
Copy link
Copy Markdown
Collaborator

Adds a tower middleware that short-circuits GET /health ahead of
jsonrpsee (which would 405 a GET) and returns {"status":"ok"}. Wired
outermost in both the HTTP and HTTPS middleware chains so load balancers
can probe before any per-request work runs.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Read-only liveness endpoint with no auth, data, or RPC behavior changes beyond skipping middleware for GET /health.

Overview
Adds a Tower HealthLayer that answers GET /health with 200 and {"status":"ok"} before jsonrpsee (which would reject GET with 405). The layer is registered outermost on both plain HTTP and HTTPS middleware stacks so probes skip CORS, OHTTP, compression, and RPC handling.

Exports HEALTH_PATH and HealthLayer from server. Unit tests cover the happy path, non-GET on /health, and GET on other paths (all fall through to the inner service).

Reviewed by Cursor Bugbot for commit 962afc1. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c26d49f. Configure here.

Comment thread crates/starknet_transaction_prover/src/server/health.rs
Copy link
Copy Markdown
Collaborator Author

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avi-starkware resolved 1 discussion.
Reviewable status: 0 of 4 files reviewed, all discussions resolved.

Copy link
Copy Markdown
Contributor

@einat-starkware einat-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@einat-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on avi-starkware).

Adds a tower middleware that short-circuits `GET /health` ahead of
jsonrpsee (which would 405 a GET) and returns `{"status":"ok"}`. Wired
outermost in both the HTTP and HTTPS middleware chains so load balancers
can probe before any per-request work runs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@avi-starkware avi-starkware changed the base branch from avi/prover-v3/log-format to graphite-base/14163 May 26, 2026 08:42
@avi-starkware avi-starkware force-pushed the avi/prover-v3/health branch from c26d49f to 962afc1 Compare May 26, 2026 08:43
@avi-starkware avi-starkware force-pushed the graphite-base/14163 branch from c219d32 to 354b15c Compare May 26, 2026 08:43
@avi-starkware avi-starkware changed the base branch from graphite-base/14163 to main May 26, 2026 08:43
@avi-starkware avi-starkware added this pull request to the merge queue May 26, 2026
Merged via the queue into main with commit ae6d2c1 May 26, 2026
20 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants