Skip to content

starknet_transaction_prover: proving-job duration + outcome metrics#14168

Open
avi-starkware wants to merge 1 commit into
avi/prover-v3/metricsfrom
avi/prover-v3/job-metrics
Open

starknet_transaction_prover: proving-job duration + outcome metrics#14168
avi-starkware wants to merge 1 commit into
avi/prover-v3/metricsfrom
avi/prover-v3/job-metrics

Conversation

@avi-starkware
Copy link
Copy Markdown
Collaborator

Adds Prometheus counters / histograms recorded by VirtualSnosProver for
each proving job: total count by outcome (success, validation_error,
internal_error, l1_provider_error) and end-to-end duration.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Observability-only changes around the prover path; no auth, fee, or proving logic behavior changes beyond refactoring into an inner method.

Overview
Adds Prometheus observability around each prove_transaction call in VirtualSnosProver: end-to-end latency (prover_prove_transaction_duration_seconds), per-request outcome counts with a fixed outcome label set (prover_prove_transaction_outcome_total), and sub-step histograms for virtual OS execution and Stwo proving.

Proving logic moves into prove_transaction_inner so the public method can always record metrics and log outcome on completion. VirtualSnosProverError::metric_outcome() maps error variants to the bounded labels in server::metrics::outcomes (validation, blocked, runner, output parse, proving).

Reviewed by Cursor Bugbot for commit fb01d37. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator Author

avi-starkware commented May 24, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@avi-starkware avi-starkware force-pushed the avi/prover-v3/job-metrics branch from 7d179cb to a0e7299 Compare May 24, 2026 16:48
@avi-starkware avi-starkware force-pushed the avi/prover-v3/metrics branch 2 times, most recently from 5eb413f to 186e4cf Compare May 26, 2026 08:43
@avi-starkware avi-starkware force-pushed the avi/prover-v3/job-metrics branch from a0e7299 to 00671e6 Compare May 26, 2026 08:43
@avi-starkware avi-starkware force-pushed the avi/prover-v3/metrics branch from 186e4cf to 9959caa Compare May 26, 2026 12:16
@avi-starkware avi-starkware force-pushed the avi/prover-v3/job-metrics branch from 00671e6 to 68683f0 Compare May 26, 2026 12:16
@avi-starkware avi-starkware force-pushed the avi/prover-v3/metrics branch from 9959caa to 1733122 Compare May 26, 2026 12:17
@avi-starkware avi-starkware force-pushed the avi/prover-v3/job-metrics branch 2 times, most recently from 00f7551 to b51be4a Compare May 26, 2026 12:58
@avi-starkware avi-starkware force-pushed the avi/prover-v3/metrics branch from 1733122 to 4403df0 Compare May 26, 2026 12:58
@avi-starkware avi-starkware force-pushed the avi/prover-v3/job-metrics branch from b51be4a to 396774b Compare May 26, 2026 16:14
@avi-starkware avi-starkware force-pushed the avi/prover-v3/metrics branch 2 times, most recently from 3e19b68 to f196a34 Compare May 26, 2026 16:47
@avi-starkware avi-starkware force-pushed the avi/prover-v3/job-metrics branch from 396774b to 6f17bb1 Compare May 26, 2026 16:47
Adds Prometheus counters / histograms recorded by `VirtualSnosProver` for
each proving job: total count by outcome (`success`, `validation_error`,
`internal_error`, `l1_provider_error`) and end-to-end duration.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@avi-starkware avi-starkware force-pushed the avi/prover-v3/job-metrics branch from 6f17bb1 to fb01d37 Compare May 26, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants